816143 - Teach AudioStream::EnsureTimeStretcherInitialized() about infallible malloc

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

Just noticed this chunk go by in a patch for bug 814708:

>+++ b/content/media/AudioStream.cpp
> bool AudioStream::EnsureTimeStretcherInitialized()
[...]
>-  soundtouch::SoundTouch* state = new soundtouch::SoundTouch();
>-  if (!state) {
>+  mTimeStretcher = new soundtouch::SoundTouch();
>+  if (!mTimeStretcher) {
>     return false;
>   }

I'm pretty sure we don't need to bother with the null-check-after-new for mTimeStretcher (or "state" in the pre-patched code), since we have infallible-malloc.  (Unless this code has somehow requested a different malloc impl)

Incidentally, that also means that EnsureTimeStretcherInitialized can become infallible (return void instead of bool) itself.   This might mean some callers can be cleaned up as well -- I didn't follow the chain up further than that.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Teach AudioStream::EnsureTimeStretcherInitialized() about infallible malloc. r=

Indeed we use infaillible malloc.

Comment 2

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ccabd35aa7d4

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ccabd35aa7d4