Closed Bug 816159 Opened 12 years ago Closed 4 years ago

Firefox freezes and Unresponsive Script after loading Microsoft Knowledge Base article in non-English languages due to lots of cross-compartment accesses

Categories

(Core :: JavaScript Engine, defect)

20 Branch
x86_64
Windows 7
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: zollern, Unassigned)

References

(Depends on 1 open bug, )

Details

(Keywords: perf)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0 Build ID: 20121128030742 Steps to reproduce: Open http://support.microsoft.com/kb/2762895/en-us Select another language to translate to (tested with Arabic, German, Dutch, Slovenian) Actual results: First, the browser loads the page properly (favicon is shown instead of the loading icon). Then, the browser freezes for a couple of seconds and does not allow any interaction. Sometimes, an unresponsive script warning is issued for (in this case for English to Arabic) Script: http://www.microsofttranslator.com/ajax/v2/widget.aspx?siteData=PPcVDCtb6VbSFZgKOk4E16C6oqgos_b88CQZYRIzKP-YKH73GnfYWj3aBe54c0tKFnlCrWFnuSoVKlMvmHXPzhKDwKGE4_YnZE4M4E65v5jgTdHwbeuNNQroSrYWq53Z&mode=manual&from=en&layout=ts&to=ar&originalDocument=/viewkb/viewkb.aspx?contentid=2762895&category=Tech:2 Tested with the latest stable and the latest Nightly for Win32 with Windows 7 Professional x64 Expected results: The page should load properly without freezing.
This is as far as I can see a bug in the page itself. My IE9 has the same issue with it.
(In reply to Matthias Versen (Matti) from comment #1) > My IE9 has the same > issue with it. MSIE 10 too, but Chrome Canary does not. SPS Profile: http://people.mozilla.com/~bgirard/cleopatra/#report=ac2344dc8f8646ec03dc978dc44d269c40414581&jankOnly=true&mergeUnbranched=true&invertCallback=true Unsure if this is a DOM or JS Issue.
Component: Untriaged → General
Keywords: perf
Product: Firefox → Core
So looking at a profile I see a bunch of: 1) property-value getting on computed style for display:none (or just not in the DOM) elements that are in deeply nested trees. This is slow, because it has to keep recomputing the style. About 30% of the profile. 2) Lots of cross-compartment proxy action. At least 50% of the profile is pure cross-compartment proxy overhead... Let's start with #2, since it keeps coming up.
Assignee: nobody → general
Status: UNCONFIRMED → NEW
Component: General → JavaScript Engine
Ever confirmed: true
Might be worth a separate bug on the computed style issue.
Summary: Firefox freezes after loading Microsoft Knowledge Base article in non-English languages → Firefox freezes after loading Microsoft Knowledge Base article in non-English languages due to lots of cross-compartment accesses
FWIW, a more recent Profile against Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130520 Firefox/24.0 ID:20130520031230 CSet: b94e996b05fd: http://people.mozilla.com/~bgirard/cleopatra/#report=5e3ad1f4ce2fe13429513297eba4788ada84493a (especially jank of second half)
Assignee: general → nobody
Two other URLs where the application freezes https://support.microsoft.com/kb/3102429 http://support.microsoft.com/kb/3112336 Tested Browser: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 See also Attachments: 20151206_script_error_kb3102429.jpg, 20151206_script_error_kb3112336.jpg Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0 IE 11 (11.0.9600.18097 Update-Version 11.0.25 KB3100773) hangs, but will not t freeze and can be used.
> Open http://support.microsoft.com/kb/2762895/en-us > Select another language to translate to (tested with Arabic, German, Dutch, Slovenian) happens exactly as described using 20160530 nightly build, both with e10s enabled and disabled. picked Português (Brasil)‎
Severity: normal → major
Summary: Firefox freezes after loading Microsoft Knowledge Base article in non-English languages due to lots of cross-compartment accesses → Firefox freezes and Unresponsive Script after loading Microsoft Knowledge Base article in non-English languages due to lots of cross-compartment accesses
Flags: needinfo?(jdemooij)
Depends on: 1281450
Bug 1281450 should have helped a bit here. I think there's more we can do for CCW accesses once we use CacheIR for all property access IC stubs, I want to get back to that soon.
Flags: needinfo?(jdemooij)
Can we mark this dependent on the CacheIR bit so we remember to revisit it when that happens?
Flags: needinfo?(jdemooij)
(In reply to Boris Zbarsky [:bz] from comment #11) > Can we mark this dependent on the CacheIR bit so we remember to revisit it > when that happens? Good point.
Depends on: CacheIR
Flags: needinfo?(jdemooij)
No hang using latest Nightly (tested on Windows 10).

A lot of compartment complexity was removed by Bug 1357862, so I believe this is addressed fully now.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: