816210 - Global searches do not cache the source text contents for displaying in the editor

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

This is a pretty minor optimization, but nevertheless..

STR:

1. Open debugger on http://htmlpad.org/debugger/
2. Type ! in the filter box
At this point, all the sources text contents are fetched and cached in preparation for the search operation. In this case, only jquery.min is fetched, since debugger.html is already loaded.
3. Delete the ! from the filter box. Manually select jquery from the menulist.
The jquery.min source is fetched again. This is redundant, since we have already cached the source.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 686221 [details] [diff] [review]
v1

Review of attachment 686221 [details] [diff] [review]:
-----------------------------------------------------------------

It will let the debuggee avoid doing the work again, which may be important in underpowered devices, so definitely yes!

Comment 3

[Victor Porof [:vporof][:vp]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=61373316b732

Comment 4

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/c376ff7fa025

Comment 5

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/c376ff7fa025