816297 - Gaia always initiates update poll early in startup

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P3)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(I thought I had filed this, but apparently not.)

STR
 (1) Reboot b2g phone

Note that during startup, we force an update check, and then start the check immediately when we go online.

We absolutely don't want to do this during early startup.  It's a waste of CPU cycles on the critical path to showing UI.  There's a reason why we have the first-check delay pref! ;)

The unpleasantness of this is also exacerbated by bug 813765.

Either marshall or etienne suggested that the FTU code someone caused us to screw up and always force an update check during early startup, even after first run.  We need to fix that.

Comment 1

[Etienne Segonzac (:etienne)]

Tested a bit more, gaia does set

|'gaia.system.checkForUpdates': true|

only when we close the FTU, not on subsequent reboots.

Marshall do you know if we do a "oh hey! a connection, let's check for updates" on the platform side?

Comment 2

[Marshall Culpepper [:marshall_law]]

(In reply to Etienne Segonzac (:etienne) from comment #1)
> Marshall do you know if we do a "oh hey! a connection, let's check for
> updates" on the platform side?

Only if a previous check failed because the network was offline. Something needs to force the initial check =/

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I always see this in logcat on early startup

I/GeckoDump(  106): XXX FIXME : Got a mozContentEvent: force-update-check

Gaia is going to be guilty until proven innocent here, sorry :).  Especially since this seemed to have regressed around the time of FTU.

Comment 4

[Etienne Segonzac (:etienne)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> I always see this in logcat on early startup
> 
> I/GeckoDump(  106): XXX FIXME : Got a mozContentEvent: force-update-check
> 
> Gaia is going to be guilty until proven innocent here, sorry :).  Especially
> since this seemed to have regressed around the time of FTU.

Eheh :)
Found it, I was innocently looking for code settings the force-check setting to true, while it was true from the get go...

Patch incoming.

Comment 5

[Etienne Segonzac (:etienne)]

Attachment: Pointer to gaia PR 6728

Comment 6

[Etienne Segonzac (:etienne)]

Julien, if you want to steal the review I'm sure Marshall won't mind :)

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 686738 [details]
Pointer to gaia PR 6728

r=me

Comment 8

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/49e53682e5fcad5753280d47ffb4c1632cc6146c

Comment 9

[sarsenyev]

Reviewed and verified on "Unagi"
Build ID:201330103070201

"Check for update" no longer offered on the Start-Up menu