816481 - [Browser] Set verbatim input type on awesomebar to prevent keyboard suggestions

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P4)

Description

[Patryk Adamczyk [:patryk] UX]

Attachment: Before and After Screen Shot

The 3 row in the top sites list is not being rendered. I am assuming the bar that is there for predictive text is causing an issue.

Comment 1

[Ben Francis [:benfrancis]]

OK, looks like predictive text is now turned on by default, we need to turn on the verbatim input mode to disable it for this text field.

Comment 2

[Chris Lee [:clee]]

UX polish, we should evaluate this against all other UI bugs the UX team is looking at.

Comment 3

[Ben Francis [:benfrancis]]

Renominating because I think it's pretty bad to have both suggestions in the awesomescreen and suggestions from the keyboard. Also this isn't a CSS/visual design bug, it just requires setting an attribute on the input tag.

Comment 4

[Patryk Adamczyk [:patryk] UX]

Not a visual design bug, looks like:
1. Keyboard / browser is not working correctly
2. Could be polish, if we're refining how the interaction design works based on Ben's comment above.

Comment 5

[David Scravaglieri [:scravag]]

We would take a patch for that

Comment 6

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/6829

Comment 7

[Ben Francis [:benfrancis]]

I have filed bug 818504 to consider turning suggestions off by default for type=text, but in the meantime this turns it off for the awesomebar

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 688781 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/6829

merged in: https://github.com/mozilla-b2g/gaia/commit/e822f0af88be1e1a063ec9d57515f0cd68bca5ae

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 688781 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/6829

Sounds good and low risk.

Comment 10

[Chris Kreinbring [:CKreinbring]]

Verified in Unagi version 20130102070202.  Turned on the word suggestion option for the keyboard but still did not see word suggestions on the awesome page.