If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Show "hidden" properties menu item should say "non-enumerable"

RESOLVED FIXED in Firefox 20

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 20
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Because that's what it is.
(Assignee)

Comment 1

5 years ago
Created attachment 686693 [details] [diff] [review]
v1
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #686693 - Flags: review?(past)
Comment on attachment 686693 [details] [diff] [review]
v1

Review of attachment 686693 [details] [diff] [review]:
-----------------------------------------------------------------

Boo! You need to change the label (blabla2?).
Attachment #686693 - Flags: review?(past) → review-
(Assignee)

Comment 3

5 years ago
(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 686693 [details] [diff] [review]
> v1
> 
> Review of attachment 686693 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Boo! You need to change the label (blabla2?).

Argh, forgot.
(Assignee)

Comment 4

5 years ago
Created attachment 686714 [details] [diff] [review]
v2
Attachment #686693 - Attachment is obsolete: true
Attachment #686714 - Flags: review?(past)
Comment on attachment 686714 [details] [diff] [review]
v2

Review of attachment 686714 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think you need to change the key. Come to think of it, it may cause additional work for localizers who will no longer like us that much. Can you post in dev-l10n or ask in #l10n what's the right thing to do for that? r=me if they are fine with it.
Attachment #686714 - Flags: review?(past) → review+
(Assignee)

Comment 6

5 years ago
Ok.
(Assignee)

Comment 7

5 years ago
Pike: I wonder if something like "show only enumerable properties" would be easier to digest in general, and it doesn't negate the name that might stay in English. and you could add a comment that "enumerable is a state of a property defined in JS. When in doubt, leave untranslated"

victorporof: that's acceptable, but it negates the default value it has now (which is true). so, if "Show non-enumerable properties" is true, then "Show only enumerable properties" would need to default to false

Panos, do you think it's an acceptable compromise to change the default pref? I somehow incline to believe it's fine (what does "hidden" mean, really?), but it's your decision.
I'm OK with that change. Are they OK with changing the key label while leaving the content the same?
(Assignee)

Comment 9

5 years ago
Created attachment 688185 [details] [diff] [review]
v3

Made the changes to the pref and, as per Pike's suggestion, added some extra explanations in the dtd file about what "enumerable" is.
(Assignee)

Updated

5 years ago
Attachment #688185 - Attachment description: v → v3
(Assignee)

Comment 10

5 years ago
(In reply to Panos Astithas [:past] from comment #8)
> I'm OK with that change. Are they OK with changing the key label while
> leaving the content the same?

Yes, as long as I change the label. Explaining what "enumerable" is brings some extra bonus points :)
(Assignee)

Updated

5 years ago
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 11

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/332e061d03b4
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/332e061d03b4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.