816548 - Show "hidden" properties menu item should say "non-enumerable"

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

Because that's what it is.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 686693 [details] [diff] [review]
v1

Review of attachment 686693 [details] [diff] [review]:
-----------------------------------------------------------------

Boo! You need to change the label (blabla2?).

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 686693 [details] [diff] [review]
> v1
> 
> Review of attachment 686693 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Boo! You need to change the label (blabla2?).

Argh, forgot.

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v2

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 686714 [details] [diff] [review]
v2

Review of attachment 686714 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think you need to change the key. Come to think of it, it may cause additional work for localizers who will no longer like us that much. Can you post in dev-l10n or ask in #l10n what's the right thing to do for that? r=me if they are fine with it.

Comment 6

[Victor Porof [:vporof][:vp]]

Ok.

Comment 7

[Victor Porof [:vporof][:vp]]

Pike: I wonder if something like "show only enumerable properties" would be easier to digest in general, and it doesn't negate the name that might stay in English. and you could add a comment that "enumerable is a state of a property defined in JS. When in doubt, leave untranslated"

victorporof: that's acceptable, but it negates the default value it has now (which is true). so, if "Show non-enumerable properties" is true, then "Show only enumerable properties" would need to default to false

Panos, do you think it's an acceptable compromise to change the default pref? I somehow incline to believe it's fine (what does "hidden" mean, really?), but it's your decision.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

I'm OK with that change. Are they OK with changing the key label while leaving the content the same?

Comment 9

[Victor Porof [:vporof][:vp]]

Attachment: v3

Made the changes to the pref and, as per Pike's suggestion, added some extra explanations in the dtd file about what "enumerable" is.

Comment 10

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #8)
> I'm OK with that change. Are they OK with changing the key label while
> leaving the content the same?

Yes, as long as I change the label. Explaining what "enumerable" is brings some extra bonus points :)

Comment 11

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/332e061d03b4

Comment 12

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/332e061d03b4