Closed
Bug 816548
Opened 12 years ago
Closed 12 years ago
Show "hidden" properties menu item should say "non-enumerable"
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 20
People
(Reporter: vporof, Assigned: vporof)
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(2 files, 1 obsolete file)
2.93 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
16.45 KB,
patch
|
Details | Diff | Splinter Review |
Because that's what it is.
Assignee | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Comment on attachment 686693 [details] [diff] [review] v1 Review of attachment 686693 [details] [diff] [review]: ----------------------------------------------------------------- Boo! You need to change the label (blabla2?).
Attachment #686693 -
Flags: review?(past) → review-
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Panos Astithas [:past] from comment #2) > Comment on attachment 686693 [details] [diff] [review] > v1 > > Review of attachment 686693 [details] [diff] [review]: > ----------------------------------------------------------------- > > Boo! You need to change the label (blabla2?). Argh, forgot.
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #686693 -
Attachment is obsolete: true
Attachment #686714 -
Flags: review?(past)
Comment 5•12 years ago
|
||
Comment on attachment 686714 [details] [diff] [review] v2 Review of attachment 686714 [details] [diff] [review]: ----------------------------------------------------------------- I don't think you need to change the key. Come to think of it, it may cause additional work for localizers who will no longer like us that much. Can you post in dev-l10n or ask in #l10n what's the right thing to do for that? r=me if they are fine with it.
Attachment #686714 -
Flags: review?(past) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Ok.
Assignee | ||
Comment 7•12 years ago
|
||
Pike: I wonder if something like "show only enumerable properties" would be easier to digest in general, and it doesn't negate the name that might stay in English. and you could add a comment that "enumerable is a state of a property defined in JS. When in doubt, leave untranslated" victorporof: that's acceptable, but it negates the default value it has now (which is true). so, if "Show non-enumerable properties" is true, then "Show only enumerable properties" would need to default to false Panos, do you think it's an acceptable compromise to change the default pref? I somehow incline to believe it's fine (what does "hidden" mean, really?), but it's your decision.
Comment 8•12 years ago
|
||
I'm OK with that change. Are they OK with changing the key label while leaving the content the same?
Assignee | ||
Comment 9•12 years ago
|
||
Made the changes to the pref and, as per Pike's suggestion, added some extra explanations in the dtd file about what "enumerable" is.
Assignee | ||
Updated•12 years ago
|
Attachment #688185 -
Attachment description: v → v3
Assignee | ||
Comment 10•12 years ago
|
||
(In reply to Panos Astithas [:past] from comment #8) > I'm OK with that change. Are they OK with changing the key label while > leaving the content the same? Yes, as long as I change the label. Explaining what "enumerable" is brings some extra bonus points :)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 11•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/332e061d03b4
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 12•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/332e061d03b4
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•