816596 - Hide the variables filter box while there are no variables to filter

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Comment 1

[Victor Porof [:vporof][:vp]]

..and, while we're at it, it should also have a fixed position while scrolling.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v1.1

Whoops, forgot to qfold tests.

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v1.2

Rebased.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 688231 [details] [diff] [review]
v1.2

Review of attachment 688231 [details] [diff] [review]:
-----------------------------------------------------------------

Like, RT, +1.

::: browser/devtools/debugger/test/browser_dbg_propertyview-filter-01.js
@@ +41,5 @@
>    gDebugger.DebuggerView.Variables.enableSearch();
>    ok(gDebugger.DebuggerView.Variables._searchboxNode,
>      "There should be a searchbox available after enabling.");
> +  ok(gDebugger.DebuggerView.Variables._searchboxContainer.hidden,
> +    "The searchbox container should be hidden at this point.")

No trailing semicolon! ASI alert! ASI alert!

@@ +56,5 @@
>    gDebugger.DebuggerView.Variables.enableSearch();
>    ok(gDebugger.DebuggerView.Variables._searchboxNode,
>      "There should be a searchbox available after enabling.");
> +  ok(gDebugger.DebuggerView.Variables._searchboxContainer.hidden,
> +    "The searchbox container should be hidden at this point.")

ASI alert! Halp!

@@ +77,5 @@
>    gDebugger.DebuggerView.Variables.enableSearch();
>    ok(gDebugger.DebuggerView.Variables._searchboxNode,
>      "There should be a searchbox available after enabling again.");
> +  ok(gDebugger.DebuggerView.Variables._searchboxContainer.hidden,
> +    "The searchbox container should be hidden at this point.")

OMG!

@@ +95,5 @@
>    gDebugger.DebuggerView.Variables.searchEnabled = true;
>    ok(gDebugger.DebuggerView.Variables._searchboxNode,
>      "There should be a searchbox available after enabling again.");
> +  ok(gDebugger.DebuggerView.Variables._searchboxContainer.hidden,
> +    "The searchbox container should be hidden at this point.")

WE ARE DOOMED!

@@ +106,5 @@
>  
>  function testVariablesFiltering()
>  {
> +  ok(!gDebugger.DebuggerView.Variables._searchboxContainer.hidden,
> +    "The searchbox container should not be hidden at this point.")

WHY GOD, WHY?!?

::: browser/devtools/debugger/test/browser_dbg_propertyview-filter-02.js
@@ +43,5 @@
>      "There should be a searchbox available after enabling.");
> +  ok(gDebugger.DebuggerView.Variables._parent.parentNode.querySelector(".variables-searchinput.devtools-searchinput"),
> +    "The searchbox element should be found.");
> +  ok(gDebugger.DebuggerView.Variables._searchboxContainer.hidden,
> +    "The searchbox container should be hidden at this point.")

ASI alert!, ASI ale...*smack*

@@ +49,5 @@
>  
>  function testVariablesFiltering()
>  {
> +  ok(!gDebugger.DebuggerView.Variables._searchboxContainer.hidden,
> +    "The searchbox container should not be hidden at this point.")

*sobs*

Comment 6

[Victor Porof [:vporof][:vp]]

I REGRET NOTHING

Comment 7

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/c20c0e846ce0

Comment 8

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?rev=8a30e07815ff

Comment 9

[mcdavis941 (sporadically reading bugmail)]

https://hg.mozilla.org/mozilla-central/rev/c20c0e846ce0