Closed
Bug 816638
Opened 12 years ago
Closed 12 years ago
Add nondeterministicGetWeakMapKeys to the JS shell
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: Waldo, Assigned: jorendorff)
Details
Attachments
(1 file)
|
2.37 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
This exists on Components.utils, but we should be able to use it in JS tests as well as browser tests. JS_NondeterministicGetWeakMapKeys is the function you'd use to implement the key-getting part of this. The shell function would be implemented in js/src/shell/js.cpp, of course, and would be patterned off any of the other shell functions there.
Can we add it to TestingFunctions.cpp and remove the XPC version?
|
Assignee | |
Comment 2•12 years ago
|
||
Assignee: general → jorendorff
Attachment #687126 -
Flags: review?(kvijayan)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 687126 [details] [diff] [review]
v1
Review of attachment 687126 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #687126 -
Flags: review?(kvijayan) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•