Closed
Bug 816685
Opened 12 years ago
Closed 12 years ago
expand netwerk/protocol/http caps to 32 bits
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: mcmanus, Assigned: mcmanus)
References
Details
Attachments
(1 file)
|
29.05 KB,
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
I need 2 more caps bits for 792438 and there is just one available. this is not represented in an external interface anywhere so its best to just make the caps field 32 bits rather than adding caps2 or somesuch.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #686768 -
Flags: review?(jduell.mcbugs)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 686768 [details] [diff] [review] patch 0 Review of attachment 686768 [details] [diff] [review]: ----------------------------------------------------------------- I'd also have been fine with making it 16 bytes ::: netwerk/protocol/http/HttpBaseChannel.h @@ +256,1 @@ > int16_t mPriority; I'd also be fine with making it uint16_t. But probably not worth re-writing patch just to save 2 bytes per channel.
Attachment #686768 -
Flags: review?(jduell.mcbugs) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/20f8d2519660
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/20f8d2519660
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•