816720 - allow CSSGroupingRule.insertRule to insert non-style rules

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Cameron McCormack (:heycam)]

Currently CSSGroupingRule.insertRule only accepts a style rule.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch

If you have any good ideas about how I might test for whether the @page and @font-face rules were applied when inserted into a passing conditional rule, I can update the test.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 686797 [details] [diff] [review]
patch

> If you have any good ideas about how I might test for whether the @page and @font-face
> rules were applied 

For @font-face you might be able to detect font metrics via getBoundingClientRect or something?  No idea about @page.

As for the patch itself, do we want a whitelist here, or a blacklist of @namespace and @import?

r=me if you at least add an assert that the type is one of those two if it's not in your whitelist.

Comment 3

[Cameron McCormack (:heycam)]

I was going for a white list; I'll add an assertion.

Comment 4

[Cameron McCormack (:heycam)]

I worked in the @font-face testing, too.

https://hg.mozilla.org/integration/mozilla-inbound/rev/447dff867909

Comment 5

[Cameron McCormack (:heycam)]

(Commit message should be s/CSSRule/CSSGroupingRule/ but oh well.)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/447dff867909