816734 - Documentation for orangutan kernel module a bit confusing

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[William Lachance (:wlach)]

So I finally had a chance to test the work to make a testing input driver part of the pandaboard today, and have run into a bit of a snag. I noticed that the kernel module was now included as part of the build (woohoo!) so I decided to try and import it directly passing in the name of the simulated input device I wanted. Unfortunately, it seems not to recognize the names= parameter, and fails:

255|root@android:/ # insmod /system/lib/modules/orng.ko names=generic-720p_tou>
insmod: init_module '/system/lib/modules/orng.ko' failed (Invalid argument)

Strangely, simply insmodding the module with no parameter works fine:

255|root@android:/ # insmod /system/lib/modules/orng.ko                        

130|root@android:/ # getevent
add device 1: /dev/input/event2
  name:     "atmel-touchscreen"
could not get driver version for /dev/input/mice, Not a typewriter
add device 2: /dev/input/event1
  name:     "Panda Headset Jack"
add device 3: /dev/input/event0
  name:     "gpio-keys"

The support for specifying a "names=" parameter was working fine a few weeks ago. Any idea what changed between then and when the final module was committed?

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hey William,

I had problems with specifying names with spaces, so I introduces these (extra) device names. You can select the generic 720p touchscreen with

  insmod /system/lib/modules/orng.ko devices=generic-720p_touchscreen

I should have communicated this in a better way. Sorry.

When you look at the orangutan/kernel/devspec.h there are three field for each input device which can be used for selection: id, name and cname, 'Id' contains the device id as reported by the device, 'name' is the device name as reported by the device, and 'cname' is the internal, unique device name that is computed by mkdevinfo when the entry is generated. When loading the module, the devices to emulate can be selected by unique device name by using the parameter 'devices', by name by using the parameter 'names', or by id by using the parameters 'bustype', 'vendor', 'product', and 'version'.

Comment 2

[William Lachance (:wlach)]

Cool. I updated the docs accordingly:

https://github.com/wlach/orangutan/commit/2a78fc92cc0c76f531c883fd1289e4e06bf0707b

If that looks good to you, can we merge into the mozilla-b2g module?

Comment 3

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #2)
> Cool. I updated the docs accordingly:
> 
> https://github.com/wlach/orangutan/commit/
> 2a78fc92cc0c76f531c883fd1289e4e06bf0707b
> 
> If that looks good to you, can we merge into the mozilla-b2g module?

Ok, let's have another try at resolving this. I just updated the README to reflect your comments:

https://github.com/wlach/orangutan/commit/fa30f2add7e6dd2c9437e3d511c5b2bdf0834a57

Thomas: Could you tell me if they look reasonable?

Comment 4

[William Lachance (:wlach)]

Hi Thomas, see above. If you could let me know if my doc updates are now ok, that would be great. :)

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi!

Looks good to me. Can you send me a pull request?

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Merged

https://github.com/mozilla-b2g/orangutan/commit/1735c3c4d6008d7f9e929d55ed0e06b995156fa2