816846 - Error message when two attributes with the same name are defined in a WebIDL interface is ... obtuse

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It goes something like this:

  File "/Users/bzbarsky/mozilla/debug/mozilla/dom/bindings/parser/WebIDL.py", line 299, in resolve
    scope.ensureUnique(self, object)
  File "/Users/bzbarsky/mozilla/debug/mozilla/dom/bindings/parser/WebIDL.py", line 217, in ensureUnique
    object)
  File "/Users/bzbarsky/mozilla/debug/mozilla/dom/bindings/parser/WebIDL.py", line 477, in resolveIdentifierConflict
    originalObject, newObject)
TypeError: resolveIdentifierConflict() takes exactly 5 arguments (4 given)

whereas it would be better if it produced something like:

WebIDL.WebIDLError: error: Multiple unresolvable definitions of identifier 'documentElement' in scope 'Interface 'Document'
        '<unresolved scope>::ElementOrNull' attribute '::Document::documentElement' at Document.webidl line 46:11
  readonly attribute Element? documentElement;
           ^
        'Long' attribute '<unresolved scope>::documentElement' at Document.webidl line 47:11
  readonly attribute long documentElement;
           ^

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Correctly call up to our superclass to resolve an identifier conflict.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 686932 [details] [diff] [review]
Correctly call up to our superclass to resolve an identifier conflict.

Review of attachment 686932 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

Comment 3

[Boris Zbarsky [:bzbarsky]]

dzbarsky caught the problem, fwiw.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e539177376ea

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e539177376ea