Closed Bug 816878 Opened 13 years ago Closed 13 years ago

Remove all reopenSelf workaround in web activity caller

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-basecamp:-)

RESOLVED DUPLICATE of bug 801520
blocking-basecamp -

People

(Reporter: alive, Assigned: alive)

Details

Attachments

(1 file)

When working on Bug 816008, I found that many apps don't remove the workaround of reopenSelf when activity ends. This is causing problem when home key is pressed. STR: 1. Open SMS app 2. Click new message 3. Click contact icon 4. Press home button Expected: 1. All frames are closed, return to homescreen Actual: 1. The sms app are reopen itself, causing a very strange UX. Note: This should be removed long time ago but no body did... Patch incoming.
Attached file PR6742
Patch: Remove all workaround about reopenSelf(), which is causing buggy behavior to home button NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed: Risk to taking this patch (and alternatives if risky):
Attachment #686994 - Flags: review?(21)
Attachment #686994 - Flags: approval-gaia-master?(21)
Comment on attachment 686994 [details] PR6742 I feel like what you're doing is bug 801520. Let's ask David for review and you may want to move your patch there to gain bb+ and don't need approval ;)
Attachment #686994 - Flags: review?(dflanagan)
Attachment #686994 - Flags: review?(21)
Attachment #686994 - Flags: approval-gaia-master?(21)
blocking- Please re-nominate with comments if joining in with 801520 is not sufficient to resolve this.
blocking-basecamp: ? → -
Marking this as a dupe of 801520, reassigning that bug to Alive, copying Alive's pull request to that bug, and granting r+ over there. Thanks Alive!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
Comment on attachment 686994 [details] PR6742 marking r+ here, too, so it disappears from my request queue. But land it as part of the other bug.
Attachment #686994 - Flags: review?(dflanagan) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: