Closed Bug 816885 Opened 7 years ago Closed 7 years ago

LayerManagerOGL.cpp:1706:1: warning: ‘float mozilla::layers::GetDisplayportCoverage(const mozilla::gfx::Rect&, const gfx3DMatrix&, const nsIntRect&)’ defined but not used [-Wunused-function]

Categories

(Core :: Graphics: Layers, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

New build warning:
{
mozilla/gfx/layers/opengl/LayerManagerOGL.cpp:1706:1: warning: ‘float mozilla::layers::GetDisplayportCoverage(const mozilla::gfx::Rect&, const gfx3DMatrix&, const nsIntRect&)’ defined but not used [-Wunused-function]
}

This function, "GetDisplayportCoverage", is defined unconditionally but it's only called in a "#ifdef MOZ_ANDROID_OMTC" block.

We should bracket its definition with #ifdef MOZ_ANDROID_OMTC, too.
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #686996 - Flags: review?(chrislord.net)
Comment on attachment 686996 [details] [diff] [review]
fix

Review of attachment 686996 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, sorry for not spotting this.
Attachment #686996 - Flags: review?(chrislord.net) → review+
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/167b31ff36c2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.