Closed
Bug 816885
Opened 13 years ago
Closed 13 years ago
LayerManagerOGL.cpp:1706:1: warning: ‘float mozilla::layers::GetDisplayportCoverage(const mozilla::gfx::Rect&, const gfx3DMatrix&, const nsIntRect&)’ defined but not used [-Wunused-function]
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.11 KB,
patch
|
cwiiis
:
review+
|
Details | Diff | Splinter Review |
New build warning:
{
mozilla/gfx/layers/opengl/LayerManagerOGL.cpp:1706:1: warning: ‘float mozilla::layers::GetDisplayportCoverage(const mozilla::gfx::Rect&, const gfx3DMatrix&, const nsIntRect&)’ defined but not used [-Wunused-function]
}
This function, "GetDisplayportCoverage", is defined unconditionally but it's only called in a "#ifdef MOZ_ANDROID_OMTC" block.
We should bracket its definition with #ifdef MOZ_ANDROID_OMTC, too.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #686996 -
Flags: review?(chrislord.net)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 686996 [details] [diff] [review]
fix
Review of attachment 686996 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, sorry for not spotting this.
Attachment #686996 -
Flags: review?(chrislord.net) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
np, thanks for the quick review! Pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/167b31ff36c2
|
|
Assignee | |
Updated•13 years ago
|
Flags: in-testsuite-
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•