Closed Bug 816888 Opened 7 years ago Closed 7 years ago

XPCShellEnvironment.cpp:281:15: warning: unused variable ‘script’ [-Wunused-variable]

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Newish build warning:

{
ipc/testshell/XPCShellEnvironment.cpp:281:15: warning: unused variable ‘script’ [-Wunused-variable]
}

This is from bug 805080, which replaced code that sets the |script| variable with new code that redeclares it in a more limited scope:
https://hg.mozilla.org/mozilla-central/rev/139f53c8e5d8#l1.12

We can just remove the original "script" declaration pointed to by the build warning.
Attached patch fixSplinter Review
This leaves the directory warning-free, at least on my machine, so this includes a FAIL_ON_WARNINGS annotation to mark it as such.
Assignee: general → dholbert
Status: NEW → ASSIGNED
Attachment #686997 - Flags: review?(terrence)
Comment on attachment 686997 [details] [diff] [review]
fix

Review of attachment 686997 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the catch!
Attachment #686997 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/de5b83cdbfea
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.