816913 - B2G RIL: update phoneState when there's an incoming call

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P4)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

We doesn't change gAudioManager.phoneState to PHONE_STATE_RING_TONE correctly when there comes an incoming call. We should fix that.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: patch: update gAudioManager.phoneState as PHONE_STATE_RING_TONE

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 687017 [details] [diff] [review]
patch: update gAudioManager.phoneState as PHONE_STATE_RING_TONE

Should address comments per discussion.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch v2

This patch gathered scatters of 'active call determination' in ril_worker and RadioInterfaceLayer. The determination was centralized in 'updateCallAudioState()'

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch v2

This is the correct v2.

Comment 5

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

This patch LGTM. AudioManager use MODE_RING to work-around the sound-leakage problem(for ex, answer MT call, the ringtone may delay several m-sec to stop).

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Randy Lin [:rlin] from comment #5)
> This patch LGTM. AudioManager use MODE_RING to work-around the sound-leakage
> problem(for ex, answer MT call, the ringtone may delay several m-sec to
> stop).

Randy, thanks for your feedback :)

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

bb? because we should fix the wrong phoneState.

Comment 8

[Andrew Overholt [:overholt]]

Hsin-Yi, what will happen if we don't fix this?

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Andrew,

If we don't fix this bug, there could be ringtone leakage problem. I.e. When you answer the incoming call by press the answer key, the ringetone would still play, and the remote party may hear that sound.
Details as Randy explained in comment 5. Thanks!

Comment 10

[JP Rosevear [:jpr]]

Soft blocking.

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2bf2896077db

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2bf2896077db

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 687656 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: please see comment 9
Testing completed (on m-c, etc.): pushed to m-c already
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: no

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 687656 [details] [diff] [review]
Patch v2

no bb+ but also doesn't look to affect mainstream FF so approving for uplift.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1836c88ebe4d
https://hg.mozilla.org/releases/mozilla-beta/rev/e4c009042e6f