816936 - Need "New Private Window" in dock context menu for per-window private browsing.

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Firefox needs "New Private Window" in dock context menu for per-window private browsing.

Comment 1

[(no longer active)]

This sounds like a good idea, but we won't block shipping per-window private browsing on it.  However it would be very nice to have, indeed!

Steven, can you please give me an idea on how these dock menu items should be added?  Thanks!

Comment 2

[Josh Matthews [:jdm]]

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/macBrowserOverlay.xul looks useful.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

> Steven, can you please give me an idea on how these dock menu items should
> be added?

I actually don't know much about manipulating the Dock, but a quick web search turned up the "Dock Tile Programming Guide" (https://developer.apple.com/library/mac/#documentation/Carbon/Conceptual/customizing_docktile/intro/dockintro.html), which has a section called "Dynamically Adding Menu Items With the Application Delegate" (https://developer.apple.com/library/mac/#documentation/Carbon/Conceptual/customizing_docktile/docktasks_cocoa/docktasks_cocoa.html#//apple_ref/doc/uid/TP30000986-CH3-SW1, scroll down to see it).  We're already doing this at [MacApplicationDelegate applicationDockMenu:] in toolkit/xre/MacApplicationDelegate.mm.

And we already have an nsIMacDockSupport interface, implemented in widget/cocoa/nsMacDockSupport.mm.

> Thanks!

You're most welcome.  Good luck!

Comment 4

[(no longer active)]

Attachment: Patch (v1)

Comment 5

[Josh Matthews [:jdm]]

Comment on attachment 688093 [details] [diff] [review]
Patch (v1)

Review of attachment 688093 [details] [diff] [review]:
-----------------------------------------------------------------

This should go through the OpenBrowserWindowFromDockMenu function instead. Add an options argument there.

Comment 6

[(no longer active)]

Attachment: Patch (v2)

Fair enough.

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/9acb9a9eaeb3