Need "New Private Window" in dock context menu for per-window private browsing.

RESOLVED FIXED in Firefox 20

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: tetsuharu, Assigned: Ehsan)

Tracking

Trunk
Firefox 20
x86
macOS
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Firefox needs "New Private Window" in dock context menu for per-window private browsing.
Blocks: PBnGen
Keywords: uiwanted
Blocks: fxPBnGen
This sounds like a good idea, but we won't block shipping per-window private browsing on it.  However it would be very nice to have, indeed!

Steven, can you please give me an idea on how these dock menu items should be added?  Thanks!
No longer blocks: PBnGen, fxPBnGen
Assignee: nobody → ehsan
> Steven, can you please give me an idea on how these dock menu items should
> be added?

I actually don't know much about manipulating the Dock, but a quick web search turned up the "Dock Tile Programming Guide" (https://developer.apple.com/library/mac/#documentation/Carbon/Conceptual/customizing_docktile/intro/dockintro.html), which has a section called "Dynamically Adding Menu Items With the Application Delegate" (https://developer.apple.com/library/mac/#documentation/Carbon/Conceptual/customizing_docktile/docktasks_cocoa/docktasks_cocoa.html#//apple_ref/doc/uid/TP30000986-CH3-SW1, scroll down to see it).  We're already doing this at [MacApplicationDelegate applicationDockMenu:] in toolkit/xre/MacApplicationDelegate.mm.

And we already have an nsIMacDockSupport interface, implemented in widget/cocoa/nsMacDockSupport.mm.

> Thanks!

You're most welcome.  Good luck!
Posted patch Patch (v1) (obsolete) — Splinter Review
Attachment #688093 - Flags: review?(josh)
Comment on attachment 688093 [details] [diff] [review]
Patch (v1)

Review of attachment 688093 [details] [diff] [review]:
-----------------------------------------------------------------

This should go through the OpenBrowserWindowFromDockMenu function instead. Add an options argument there.
Attachment #688093 - Flags: review?(josh) → review-
Posted patch Patch (v2)Splinter Review
Fair enough.
Attachment #688093 - Attachment is obsolete: true
Attachment #688096 - Flags: review?(josh)
Attachment #688096 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/9acb9a9eaeb3
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: uiwanted
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.