Closed
Bug 816949
Opened 12 years ago
Closed 12 years ago
Make the WebM reader set the media as not seekable if it does not have an index.
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: padenot, Assigned: padenot)
References
Details
Attachments
(1 file)
10.43 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
This is followup from bug 455165 that introduced the concept of "media seekable" and "transport seekable".
Assignee | ||
Comment 1•12 years ago
|
||
This removes IsSeekableInBufferedRange() and make the necessary adjustments.
Attachment #689258 -
Flags: review?(cpearce)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → paul
Comment 2•12 years ago
|
||
Comment on attachment 689258 [details] [diff] [review] Remove IsSeekableInBufferedRange() methods as they are not needed anymore. r= Review of attachment 689258 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Paul! ::: content/media/MediaDecoder.cpp @@ +1240,5 @@ > // server supports range requests, etc.) > if (!IsMediaSeekable()) { > return NS_OK; > + } else if (!IsTransportSeekable()) { > + if (IsMediaSeekable()) { You can only get here if IsMediaSeekable() is true, so you don't need this check; so this branch can be: } else if (!IsTransportSeekable()) { return GetBuffered(aSeekable); } else { double end = IsInfinite() ? std::numeric_limits<double>::infinity() // etc... }
Attachment #689258 -
Flags: review?(cpearce) → review+
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2b2a4f11e4ab
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•