816949 - Make the WebM reader set the media as not seekable if it does not have an index.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Paul Adenot (:padenot)]

This is followup from bug 455165 that introduced the concept of "media seekable" and "transport seekable".

Comment 1

[Paul Adenot (:padenot)]

Attachment: Remove IsSeekableInBufferedRange() methods as they are not needed anymore. r=

This removes IsSeekableInBufferedRange() and make the necessary adjustments.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 689258 [details] [diff] [review]
Remove IsSeekableInBufferedRange() methods as they are not needed anymore. r=

Review of attachment 689258 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Paul!

::: content/media/MediaDecoder.cpp
@@ +1240,5 @@
>    // server supports range requests, etc.)
>    if (!IsMediaSeekable()) {
>      return NS_OK;
> +  } else if (!IsTransportSeekable()) {
> +    if (IsMediaSeekable()) {

You can only get here if IsMediaSeekable() is true, so you don't need this check; so this branch can be:

} else if (!IsTransportSeekable()) {
  return GetBuffered(aSeekable);
} else {
  double end = IsInfinite() ? std::numeric_limits<double>::infinity()
  // etc...
}

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/2b2a4f11e4ab