Closed
Bug 816959
Opened 13 years ago
Closed 13 years ago
BaselineCompiler: Attach type monitor stubs
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
9.94 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
Takes SS 3bit-bits-in-byte from 11 ms to 6 ms.
Attachment #687064 -
Flags: review?(kvijayan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 687064 [details] [diff] [review]
Patch
Review of attachment 687064 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/BaselineIC.cpp
@@ +167,5 @@
> types::TypeScript::Monitor(cx, script, pc, value);
>
> + if (!stub->addMonitorStubForValue(cx, value))
> + return false;
> +
Good that you noticed this :)
Attachment #687064 -
Flags: review?(kvijayan) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•