816977 - hgtool.py (/mozharness) should not use error strings with hgtool fallbacks

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Ed Morley [:emorley]]

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=17487727&tree=Firefox&full=1#error0

{
05:58:35     INFO - #####
05:58:35     INFO - ##### Running checkout-gaia step.
05:58:35     INFO - #####
05:58:35     INFO - Running command: ['hgtool.py', '--mirror', u'http://hg-internal.dmz.scl3.mozilla.com/integration/gaia-nightly', '--bundle', u'http://ftp.mozilla.org/pub/mozilla.org/firefox/bundles/gaia-nightly.hg', u'http://hg.mozilla.org/integration/gaia-nightly', '/builds/slave/b2g-m-cen-unagi-dep/build/gaia']
05:58:35     INFO - Copy/paste: hgtool.py --mirror http://hg-internal.dmz.scl3.mozilla.com/integration/gaia-nightly --bundle http://ftp.mozilla.org/pub/mozilla.org/firefox/bundles/gaia-nightly.hg http://hg.mozilla.org/integration/gaia-nightly /builds/slave/b2g-m-cen-unagi-dep/build/gaia
05:58:35     INFO -  Checking if share extension works
05:58:35     INFO -  command: START
05:58:35     INFO -  command: hg help share
05:58:35     INFO -  command: cwd: /builds/slave/b2g-m-cen-unagi-dep
05:58:35     INFO -  command: output:
05:58:36     INFO -  command: END (0.38 elapsed)
05:58:36     INFO -  Updating shared repo
05:58:36     INFO -  Attempting to initialize clone with bundles
05:58:36     INFO -  command: START
05:58:36     INFO -  command: hg init /builds/hg-shared/integration/gaia-nightly
05:58:36     INFO -  command: cwd: /builds/slave/b2g-m-cen-unagi-dep
05:58:36     INFO -  command: output:
05:58:36     INFO -  command: END (0.64s elapsed)
05:58:36     INFO -  Trying to use bundle http://ftp.mozilla.org/pub/mozilla.org/firefox/bundles/gaia-nightly.hg
05:58:36     INFO -  command: START
05:58:36     INFO -  command: hg unbundle http://ftp.mozilla.org/pub/mozilla.org/firefox/bundles/gaia-nightly.hg
05:58:36     INFO -  command: cwd: /builds/hg-shared/integration/gaia-nightly
05:58:36     INFO -  command: output:
05:58:37    ERROR -  abort: HTTP Error 404: Not Found
05:58:37    ERROR -  Automation Error: hg not responding
}

TBPL matches on both the "ERROR" log level prefix & also "abort:" (albeit the latter is currently "^abort:" so with the prefix wouldn't get caught).

We should get mozharness to mark these as WARNING or INFO, rather than ERROR.

Comment 1

[Ed Morley [:emorley]]

This might actually be caused by the bustage from bug 816793 instead

Comment 2

[[e-mail] (:bhearsum)]

Aki, this caused issues with the otoro/unagi/panda multilocale builds today. What should we do?

Comment 3

[Aki Sasaki (not active)]

As stated in IRC, this most likely caused confusion but not burning.
We found some build bustage that actually cauesd the multilocale red.

I'm going to fix this, but this shouldn't strictly block rolling out multilocale.

Comment 4

[Aki Sasaki (not active)]

Attachment: make a 404 a WARNING for hgtool only

We're really going by the exit code here, so we should be fine with this as a WARNING or even an INFO.

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 687334 [details] [diff] [review]
make a 404 a WARNING for hgtool only

http://hg.mozilla.org/build/mozharness/rev/91eac188a233