816985 - BaselineCompiler: Compile GETGNAME

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

We need this for most of the interesting benchmarks and tests.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1: Fix some bugs

With GETGNAME we compile a lot more code and this uncovered various problems, mostly frame stuff. The Bailed_BaselineStub is used when baseline calls directly into Ion and the Ion frame bails out.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 2: Compile GETGNAME

Adds an IC for GETGNAME. Also fixes two other bugs:

* Ion does not save/restore the frame pointer, so we have to restore the stack pointer from the frame descriptor when we call an Ion-compiled function.

* x64-only: using boxValue with the same source and dest register is invalid. The patch adds an assert to boxValue and uses tagValue for now.

Comment 3

[Kannan Vijayan [:djvj]]

Comment on attachment 687374 [details] [diff] [review]
Part 1: Fix some bugs

Review of attachment 687374 [details] [diff] [review]:
-----------------------------------------------------------------

Everything looks OK, but I am not very familiar with the frame code.  For example, I don't understand why we need to change frame types for JS, BaselineStub, and Rectifier to "Bailed" variants when their children bail.

I can't see anything really wrong with the changes, though.  R+ing.

Comment 4

[Kannan Vijayan [:djvj]]

Comment on attachment 687380 [details] [diff] [review]
Part 2: Compile GETGNAME

Review of attachment 687380 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 5

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/projects/ionmonkey/rev/b798b93ae2bb
https://hg.mozilla.org/projects/ionmonkey/rev/fb49fab1d534