Closed
Bug 816995
Opened 12 years ago
Closed 12 years ago
Use openUILinkIn instead of the gBrowser.selectedTab = gBrowser.addTab() pattern
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
|
9.23 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
see bug 816197 comment 20
Attachment #687101 -
Flags: review?(dtownsend+bugmail)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 687101 [details] [diff] [review] patch Review of attachment 687101 [details] [diff] [review]: ----------------------------------------------------------------- As long as this doesn't cause the tabs to be open in the background in some configurations, it looks to me like it won't though.
Attachment #687101 -
Flags: review?(dtownsend+bugmail) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/87c471673853
Flags: in-testsuite-
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/87c471673853
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
||
Comment 4•12 years ago
|
||
(In reply to Dave Townsend from comment #1) > As long as this doesn't cause the tabs to be open in the background It seems to me you could set inBackground to false or fromChrome to true, either of which would work (I didn't look to see why you have two ways to do this; as it happens SeaMonkey works slightly differently, it uses a "tabfocused" target instead.)
|
||
Comment 5•12 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #4) > (In reply to Dave Townsend from comment #1) > > As long as this doesn't cause the tabs to be open in the background > It seems to me you could set inBackground to false or fromChrome to true, openUILinkIn always sets fromChrome to true when calling openLinkIn.
You need to log in
before you can comment on or make changes to this bug.
Description
•