816995 - Use openUILinkIn instead of the gBrowser.selectedTab = gBrowser.addTab() pattern

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

see bug 816197 comment 20

Comment 1

[Dave Townsend [:mossop]]

Comment on attachment 687101 [details] [diff] [review]
patch

Review of attachment 687101 [details] [diff] [review]:
-----------------------------------------------------------------

As long as this doesn't cause the tabs to be open in the background in some configurations, it looks to me like it won't though.

Comment 2

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87c471673853

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/87c471673853

Comment 4

[[e-mail]]

(In reply to Dave Townsend from comment #1)
> As long as this doesn't cause the tabs to be open in the background
It seems to me you could set inBackground to false or fromChrome to true, either of which would work (I didn't look to see why you have two ways to do this; as it happens SeaMonkey works slightly differently, it uses a "tabfocused" target instead.)

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to [e-mail] from comment #4)
> (In reply to Dave Townsend from comment #1)
> > As long as this doesn't cause the tabs to be open in the background
> It seems to me you could set inBackground to false or fromChrome to true,

openUILinkIn always sets fromChrome to true when calling openLinkIn.