817102 - Copy/paste from about:telemetry has no line breaks

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Steve Fink [:sfink] [:s:]]

Copy/paste from about:telemetry loses line breaks and is mostly unreadable. (Specifically, I was copying the slow sql query table.)

HitsAvg. Time (ms)Statement3342SELECT COUNT(1) AS numLogins FROM moz_logins WHERE (hostname = :hostname) AND (httpRealm isnull) /* signons.sqlite */18146COMMIT TRANSACTION /* formhistory.sqlite */7198UPDATE moz_logins SET hostname = :hostname, httpRealm = :httpRealm, formSubmitURL = :formSubmitURL, usernameField = :usernameField, passwordField = :passwordField, encryptedUsername = :encryptedUsername, encryptedPassword = :encryptedPassword, guid = :guid, encType = :encType, timeCreated = :timeCreated, timeLastUsed = :timeLastUsed, timePasswordChanged = :timePasswordChanged, timesUsed = :timesUsed WHERE id = :id /* signons.sqlite */

Comment 1

[Vladan Djeric (:vladan)]

Attachment: Add newlines & tabs to cell text

This patch adds newlines & tabs to table cells in the "Slow SQL", "Simple Measurements" and "System Info" sections.

Copied text from "Slow SQL" section:
------------------------------------------

Slow SQL Statements on Main Thread
Hits	Avg. Time (ms)	Statement
1	106	COMMIT TRANSACTION /* formhistory.sqlite */
1	194	RELEASE SAVEPOINT :private /* extensions.sqlite */
Slow SQL Statements on Helper Threads
Hits	Avg. Time (ms)	Statement
2	132	UPDATE moz_places SET title = :page_title WHERE id = :page_id  /* places.sqlite */
10	155	COMMIT TRANSACTION /* places.sqlite */


Copied text from "Browser Hangs" section:
------------------------------------------

        Memory map:
mozjs.dll 1 {8a4e6d4a-7dc0-4fd3-aeb5-8b4427b9a1d5} mozjs.pdb
xul.dll 1 {b5998ed6-e4b9-4d17-b520-0d2e372860e8} xul.pdb
firefox.exe 1 {df04e871-5c48-4551-966b-8c692bda0377} firefox.pdb
kernel32.dll 2 {d08f1e13-1d1f-4d97-b4ab-2f64e00cfc8b} wkernel32.pdb
ntdll.dll 2 {d74f79eb-1f8d-4a45-abcd-2f476ccabacc} wntdll.pdb

Hang Report #1 (3 seconds)
Stack: 0,988413 0,469944 0,474903 0,399837 0,380131 0,399108 0,361324 0,361077 0,34217 1,6378803 1,6359545 1,9966647 1,6462576 1,6483383 0,394362 0,371995 0,399108 0,394557 0,258162 0,394362 0,371995


Copied text from "Simple Measurements" section:
------------------------------------------

Property	Value
uptime	2
start	45
main	66
startupCrashDetectionBegin	138
startupCrashDetectionEnd	31731
firstPaint	1681

Copied text from "System Info" section:
------------------------------------------

Property	Value
reason	gather-payload
OS	WINNT
appID	{ec8030f7-c20a-464f-9b0e-13a3a9e97384}
appVersion	20.0a1
appName	Firefox

Comment 2

[Mozilla RelEng Bot]

Try run for c4d82c52bf9a is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c4d82c52bf9a
Results (out of 3 total builds):
    success: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-c4d82c52bf9a

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 695573 [details] [diff] [review]
Add newlines & tabs to cell text

Review of attachment 695573 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 4

[Vladan Djeric (:vladan)]

Comment on attachment 695573 [details] [diff] [review]
Add newlines & tabs to cell text

https://hg.mozilla.org/integration/mozilla-inbound/rev/649dfcc03f38

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/649dfcc03f38