817330 - test_bug458898.html fails if dom.disable_window_move_resize = true

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch

test_bug458898.html constantly fails with SeaMonkey. Example:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1354379420.1354380578.1902.gz#err1

16424 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug458898.html | innerHeight: 0 >= 200 ?

I tracked the problem down to pref dom.disable_window_move_resize which is currently:
- false by default and for FF (all.js, firefox.js)
- true by default for B2G, Mobile and SM (b2g.js, mobile.js, browser-prefs.js)

Attached a patch that sets/resets the pref within the test. With that the test succeeds with SeaMonkey.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 687443 [details] [diff] [review]
patch

I prefer the pattern of setting the pref back to its original value at the end rather than clearing it.  (If its original value was the default, this has the same effect as clearing it.)

So in other words, add before your setBoolPref line:

  var oldPref = SpecialPowers.getBoolPref(disableWindowResizePref);

and then replace your clearUserPref line with a setBoolPref call with oldPref as the argument.

r=dbaron with that

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v2

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9cbf17ad438a

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9cbf17ad438a

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Verified: The error has vanished from
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1354637066.1354638195.18671.gz