817332 - Remove XPIDL for HTMLPropertiesCollection/PropertyNodeList

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 687446 [details] [diff] [review]
Patch

The whitespace cleanup is all good, but please try to do that in a separate patch from the substantive changes next time?

>+++ b/content/html/content/src/HTMLPropertiesCollection.h
> class HTMLPropertiesCollection : public nsIHTMLCollection,
>+  NS_IMETHOD GetLength(uint32_t* aLength);
>+  NS_IMETHOD Item(uint32_t aIndex, nsIDOMNode** aResult);

How about you remove these, and the manual "NS_IMETHOD NamedItem(const nsAString& aName, nsIDOMNode** aResult);" and just NS_DECL_NSIDOMHTMLCOLLECTION?

> class PropertyNodeList : public nsINodeList,
>+  NS_IMETHOD GetLength(uint32_t* aLength);
>+  NS_IMETHOD Item(uint32_t aIndex, nsIDOMNode** aReturn);

NS_DECL_NSIDOMNODELIST

>+++ b/content/html/content/src/nsGenericHTMLElement.h
>+  NS_IMETHOD GetProperties(nsISupports** aReturn)   \
>       MOZ_FINAL {                                                              \
>-    nsGenericHTMLElement::GetProperties(aReturn);                              \
>+    mozilla::dom::HTMLPropertiesCollection* collection; \
>+        nsGenericHTMLElement::GetProperties(&collection);                              \
>+          *aReturn = static_cast<nsIHTMLCollection*>(collection); \

Please fix the indentation here, and the alignment of the backslashes.

Yay less classinfo!

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 687446 [details] [diff] [review]
Patch

Review of attachment 687446 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/HTMLPropertiesCollection.cpp
@@ -493,5 @@
> -  EnsureFresh();
> -  nsCOMPtr<nsIWritableVariant> out = new nsVariant();
> -
> -  // We have to use an nsTArray<nsIVariant*> here and do manual refcounting because 
> -  // nsWritableVariant::SetAsArray takes an nsIVariant**.

Bye, nsIVariant, you won't be missed \o/

::: content/html/content/src/HTMLPropertiesCollection.h
@@ +17,5 @@
>  #include "nsINodeList.h"
>  #include "nsIHTMLCollection.h"
>  #include "nsHashKeys.h"
>  #include "nsRefPtrHashtable.h"
> +#include "jsfriendapi.h"

Anything in particular you needed this for?

::: content/html/content/src/nsGenericHTMLElement.cpp
@@ +4101,5 @@
>    return properties;
>  }
>  
>  void
> +nsGenericHTMLElement::GetProperties(HTMLPropertiesCollection** aProperties)

Just make this return nsISupports; it's only used for the GetProperties in the macro below.

Comment 3

[David Zbarsky (:dzbarsky)]

(In reply to :Ms2ger from comment #2)
> Comment on attachment 687446 [details] [diff] [review]
> Patch
> 
> Anything in particular you needed this for?

JS::Value

Comment 4

[Boris Zbarsky [:bzbarsky]]

JS::Value is in jsapi.h.

Comment 5

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f18ed6d2717

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/2f18ed6d2717