817333 - Wrong colors in some images

Status: UNCONFIRMED

(Core :: Graphics: Color Management, defect)

Description

[Vlad Volkov]

Attachment: ff17_green_pngs.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:19.0) Gecko/20121201 Firefox/19.0
Build ID: 20121201072132

Steps to reproduce:

After upgrade to Firefox 17 some images are displayed in wrong colors (sometimes that looks really weird - see the attached screenshot for example).

So far, I found out the following:
- colors are distorted, it seems, only in PNG images with transparent background; images on the web and toolbar icons are all affected;
- the problem is present in versions 17.0 and Aurora 19.0a2 (2012-12-01), but there is no problem in 16.0.2;
- the issue manifests itself in safe mode and in a clean profile in both 17 and 19 versions;
- setting gfx.color_management.mode to 0 (as suggested here: https://bugzilla.mozilla.org/show_bug.cgi?id=660764) fixes the problem.

OS: Ubuntu 12.04 32bit, open-source ATI radeon drivers.
All packages were installed from standard Ubuntu repos (Aurora - from the corresponding PPA).

Comment 1

[Vlad Volkov]

Attachment: JPEG example

I was wrong about transparent PNGs only. Just found another example - a JPEG image that is also rendered with the weird green hue.

Comment 2

[Matthias Versen [:Matti]]

Could you try to find the regression range using our automated tool ?
http://mozilla.github.com/mozregression/

The tool uses trunk build and the best date for a regression after ff16 is to use the branch date: 2012-06-05

Comment 3

[Vlad Volkov]

Last good nightly: 2012-07-19
First bad nightly: 2012-07-20

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6d8456a77e57&tochange=3a05d298599e

Comment 4

[Matthias Versen [:Matti]]

i suspect bug 709732

Comment 5

[Karl Tomlinson (:karlt)]

Can you try viewing a problem image under another application that uses the monitor's color profile please?  eog or calligra-krita, for example.

Can you paste output from "xprop -root | grep ICC\\\|EDID" please?

Comment 6

[Vlad Volkov]

Attachment: xprop ICC

I tried eog and digikam (with color management on and off) - no problems with them.

I've attached the command output. It seems, xprop returned ICC profile only, no EDID information. Let me know if you need any other data.

Comment 7

[[e-mail]]

@Vlad The only case, where I could reproduce the behaviour you found, was when using a swapped channel test profile as monitor profile. eog shows the same like FireFox and is known to work with embedded ICC profiles in PNGs and with the ICC Profile in X mechanism. Both showed with the test profile as monitor profile swapped channels and with the normal monitor profile they showed normal colour channels. So did you really set up your monitor profile in the systems colour management panel? If so please attach your monitor profile here for reference.

On my ubuntu installation (12.04), Digikam was not able to use the system wide ICC monitor profile, which resides inside X. I tested with both Oyranos CMS and colord.

Comment 8

[Vlad Volkov]

Attachment: icc_profile_custom.icc

You are right, it depends on the ICC profile of the monitor.
I use custom ICC profile (attached) created with a calibrator.

If I change the profile in to the default one (using "gnome-control-center color"), and then restart Firefox, the bug disappears.

Comment 9

[Vlad Volkov]

Attachment: edid-3f59103b98318e7b6470dbb90812655c.icc

Here is the default profile for my display. With this profile no problem occurs.

Comment 10

[[e-mail]]

Thanks for the profiles. The custom one was used with a rather old version of dispcalGUI. The profile is a table based one with CIE*XYZ as PCS (profile connection space). That is rather odd and most/all CMM's will find a hard time with it. Better to use CIE*Lab as PCS or create a matrix/shaper based only profile. Otherwise the profile looks formally correct.

Comment 11

[j.j.]

So can we close this as INVALID?

Comment 12

[Karl Tomlinson (:karlt)]

Comment 10 said the profile looks "formally correct".
Sounds like something in Gecko is not interpreting it correctly nor falling back to a sensible default.  That's not INVALID as far as we know.

Comment 13

[[e-mail]]

(In reply to Karl Tomlinson (:karlt) from comment #12)
> Comment 10 said the profile looks "formally correct".
> Sounds like something in Gecko is not interpreting it correctly nor falling
> back to a sensible default.  That's not INVALID as far as we know.

"formally correct" does not mean the ICC profile in question is useful. It is obviously not. A CMM (qcms in FF) has no means to test for the profile quality. There is a entire class of applications to do quality assurance. But the profile creating software should better make the described specific ICC profile tag combination rather unlikely to get used with the *XYZ PCS.

Comment 14

[John_Ha]

I have a similar problem which only occurs when I paste an 8 bit image into TB v17.  Image type (JPG, GIF, PNG) is not a factor presumably because a memory map of the pixels is being pasted, not the JPG/GIF/PNG format file.

TB 17.0 is corrupting the colors of an 8 bit image pasted into TB using Edit > Paste or Ctrl/v. This started happening after upgrading to 17.0 - it was OK before. Steps to reproduce the error are:

Create an image with many colors - see Image 1 below

1 Save the image as test.JPG. This is a 24 bit image. Open test.JPG with an image editor (IrfanView) and Edit > Copy to copy the image. Paste the clipboard into TB using Ctrl/v. See Image 1 - the image is correct in TB.

2 Now reduce the colors to 8 bit in IrfanView by Image > Decrease Color Depth > 8 bit. Edit > Copy to copy the image to the clipboard. Paste the clipboard into TB using Ctrl/v. See Image 2 - the image has false colors.

3 Open test.JPG and save it as a GIF file. GIF files are 8 bit images. Open the GIF file and Edit > Copy to copy the image to the clipboard. Paste the clipboard into TB using Ctrl/v. See Image 3 - the image has false colors

4 Image 4 below is the correct representation of the 8 bit image. I saved it as a 24 bit image so as to get it to appear correctly.

5  It works properly if I use Insert. I have a file called test.GIF which, like all GIF files, is an 8 bit image.

If I insert the image with Insert > Image, then browse for test.GIF and choose it, it appears correctly.

If I open test.GIF, and go Edit > copy; and then paste with ctrl/v, the image is corrupted.

6  The fault appears in both Safe Mode and in Normal Mode.  

7  This bug appeared in v17 - v16 and all previous versions did not have the bug.  

See file above for image corruption. 

I believe the problem may be associated with the fact that TB decides which format an image file pasted into an email should be stored in.  Presumably, TB receives an memory map of the pixels from the clipboard, and then saves the file as a PNG for sending with the email.  Does the corruption occur in the save??

Header for an 8 bit image pasted into email - note saved as a PNG.

Content-Type: image/png;
 name="bjghiicc.png"
Content-Transfer-Encoding: base64
Content-ID: <[e-mail]>
Content-Disposition: inline;
 filename="bjghiicc.png"

iVBORw0KGgoAAAANSUhEUgAAAWYAAAFtCAIAAAC7g1eCAAAgAElEQVR4nOy9X4jd13X2vzGD
LVF4URylIxW3uahxJGhtx1jVVBj3oiGehIQ4JtEfGkxqjOMJwvWFscMb0tBgx75QpItKHuXC
... etc

See post http://forums.mozillazine.org/viewtopic.php?f=39&t=2622923

Comment 15

[John_Ha]

Attachment: 8 bit image corrupted when pasted into TB V17

This is a screen shot of 4 images pasted into TB v17 showing the corruption.

Comment 16

[Karl Tomlinson (:karlt)]

John_Ha, if setting gfx.color_management.mode to 0 in the Config Editor doesn't resolve your issue, then please revert it to the default value and file a new bug.

Comment 17

[John_Ha]

Karl
Thank you.  I set gfx.color_management.mode to 0 in the Config Editor and it made no differnce.  I reinstalled TB v17, created a new profile and ran in Safe Mode and it still happened.  
I have raised a bug report with copies of all files and message sources here https://bugzilla.mozilla.org/show_bug.cgi?id=825093