817341 - Differentiate marking and sweep-marking in GC stats

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

In order for the GC statistics to be useful, there has to be a strict hierarchy of phases. Right now, we have a problem where PHASE_MARK_DELAYED can happen both during marking and during sweeping. This patch fixes that.

I also realized that we weren't timing finalization of Ion code, so it fixes that too.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch v2

I added some extra assertions that ensure that phases are always properly nested. This found one or two problems in the previous version. Here's the updated patch.

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 687560 [details] [diff] [review]
patch v2

Review of attachment 687560 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, looks good.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/14893aa56835

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/14893aa56835

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

FYI, I accidentally checked in a patch for bug 817431 with 817341 in the summary