Differentiate marking and sweep-marking in GC stats

RESOLVED FIXED in mozilla20

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla20
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 687456 [details] [diff] [review]
patch

In order for the GC statistics to be useful, there has to be a strict hierarchy of phases. Right now, we have a problem where PHASE_MARK_DELAYED can happen both during marking and during sweeping. This patch fixes that.

I also realized that we weren't timing finalization of Ion code, so it fixes that too.
Attachment #687456 - Flags: review?(jcoppeard)
Created attachment 687560 [details] [diff] [review]
patch v2

I added some extra assertions that ensure that phases are always properly nested. This found one or two problems in the previous version. Here's the updated patch.
Attachment #687456 - Attachment is obsolete: true
Attachment #687456 - Flags: review?(jcoppeard)
Attachment #687560 - Flags: review?(jcoppeard)
Comment on attachment 687560 [details] [diff] [review]
patch v2

Review of attachment 687560 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, looks good.
Attachment #687560 - Flags: review?(jcoppeard) → review+

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/14893aa56835
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
FYI, I accidentally checked in a patch for bug 817431 with 817341 in the summary

Updated

5 years ago
Depends on: 939476
You need to log in before you can comment on or make changes to this bug.