817348 - TBPL puppet scripts should not use variables containing hyphens

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

Having just updated to Vagrant v1.0.5, I get:
{
[default] Running Puppet with /tmp/vagrant-puppet/manifests/init.pp...
stdin: is not a tty
Could not parse for environment production: Syntax error at '-'; expected '}' at /tmp/vagrant-puppet/manifests/classes/tbpl-base.pp:38 on node lucid32.hsd1.ca.comcast.net.
}

Line 38 is:
>     $main-package-list = [

It would seem that Puppet has never officially supported having hyphens in variable names, but it is only as of newer versions that this would cause an error:

http://docs.puppetlabs.com/guides/language_guide.html
{
Acceptable Characters in Names

Variable names can include alphanumeric characters and underscores, and are case-sensitive. Hyphens are not allowed; although some Puppet versions permit them, this is now considered a bug.
}

Comment 1

[Ed Morley [:emorley]]

hyphens

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 3

[Ed Morley [:emorley]]

Thank you for the review :-)

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/e1eb9d5d212d