817352 - Green Marionette runs contain connection refused exceptions marked by mozharness as ERROR level

Status: RESOLVED WORKSFORME

(Remote Protocol :: Marionette, defect)

Description

[Ed Morley [:emorley]]

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=17525192&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=17525203&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=17525372&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=17525374&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=17525369&tree=Mozilla-Inbound

{
15:52:43     INFO - #####
15:52:43     INFO - ##### Running run-marionette step.
15:52:43     INFO - #####
15:52:43     INFO - Running command: ['/home/cltbld/talos-slave/test/build/venv/bin/python', '-u', '/home/cltbld/talos-slave/test/build/tests/marionette/marionette/runtests.py', '--binary', '/home/cltbld/talos-slave/test/build/application/firefox/firefox', '--address', 'localhost:2828', '--type', 'browser', '/home/cltbld/talos-slave/test/build/tests/marionette/tests/testing/marionette/client/marionette/tests/unit-tests.ini']
15:52:43     INFO - Copy/paste: /home/cltbld/talos-slave/test/build/venv/bin/python -u /home/cltbld/talos-slave/test/build/tests/marionette/marionette/runtests.py --binary /home/cltbld/talos-slave/test/build/application/firefox/firefox --address localhost:2828 --type browser /home/cltbld/talos-slave/test/build/tests/marionette/tests/testing/marionette/client/marionette/tests/unit-tests.ini
15:52:44     INFO -  starting httpd
15:52:44     INFO -  running webserver on http://10.12.49.161:44522/
15:52:44     INFO -  starting runner
15:52:44    ERROR -  Traceback (most recent call last):
15:52:44     INFO -    File "/home/cltbld/talos-slave/test/build/tests/marionette/marionette/geckoinstance.py", line 41, in wait_for_port
15:52:44     INFO -      sock.connect((self.marionette_host, self.marionette_port))
15:52:44     INFO -    File "<string>", line 1, in connect
15:52:44     INFO -  error: [Errno 111] Connection refused
15:52:45    ERROR -  Traceback (most recent call last):
15:52:45     INFO -    File "/home/cltbld/talos-slave/test/build/tests/marionette/marionette/geckoinstance.py", line 41, in wait_for_port
15:52:45     INFO -      sock.connect((self.marionette_host, self.marionette_port))
15:52:45     INFO -    File "<string>", line 1, in connect
15:52:45     INFO -  error: [Errno 111] Connection refused
15:52:46    ERROR -  Traceback (most recent call last):
15:52:46     INFO -    File "/home/cltbld/talos-slave/test/build/tests/marionette/marionette/geckoinstance.py", line 41, in wait_for_port
15:52:46     INFO -      sock.connect((self.marionette_host, self.marionette_port))
15:52:46     INFO -    File "<string>", line 1, in connect
15:52:46     INFO -  error: [Errno 111] Connection refused
15:52:46     INFO -  1354405966418	Marionette	INFO	MarionetteComponent loaded
...
...
}

1) If this isn't a should-be-fatal error, than we should 
  (a) catch the exception
  (b) not output on a mozharness ERROR line

2) Regardless of whether this should be a fatal error or not, why is mozharness returning success to buildbot, if there was >0 ERROR lines?

Thank you! :-)

Comment 1

[Jonathan Griffin (:jgriffin)]

This is a non-fatal error, I'll clean up the error handling code in the mozharness script.

Comment 2

[Ed Morley [:emorley]]

(In reply to Jonathan Griffin (:jgriffin) from comment #1)
> This is a non-fatal error, I'll clean up the error handling code in the
> mozharness script.

Great, thank you :-)

Will this fix #2 from comment 0 too, or should I file separately?

Comment 3

[Jonathan Griffin (:jgriffin)]

(In reply to Ed Morley [UTC+0; email:edmorley@moco] from comment #2)
> (In reply to Jonathan Griffin (:jgriffin) from comment #1)
> > This is a non-fatal error, I'll clean up the error handling code in the
> > mozharness script.
> 
> Great, thank you :-)
> 
> Will this fix #2 from comment 0 too, or should I file separately?

I can fix them at the same time.

Comment 4

[Aki Sasaki (not active)]

Still an issue?

Comment 5

[David Burns :automatedtester]

Looks to be fine now on treeherder