81739 - onKeyPress event handler can't cancel form.submit triggered by pressing Enter in text input [form sub]

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[David Manz]

If there is a single input type=text on a page, pressing enter in the input will
cause the form to be submitted.  In both IE and Netscape 4, this can be prevented
by returning false from an onKeyPress event handler.  However, this does not work
in Mozilla.

Comment 1

[David Manz]

Attachment: simple test case

Comment 2

[Vladimir Ermakov]

onkeypress handler is handled by the form before it reaches the text box 
check... looks like the form captures the return key. Even if I add this handler 
 to form itself the enter key submits it before reaching the handler. 
 The only workabout I could come up with is this:

if(keycode == 13) {
    if(e.stopPropagation)
     e.stopPropagation();
    return false; }
}

if(document.addEventListener)
  document.addEventListener("keypress",cancelSubmit,1); 

Basicly capture the event at document level and not let it go any further. This 
works for not submitting the form, but if there is a text area you wont be able 
to go to the next line.

Comment 3

[rods (gone)]

reassigning

Comment 4

[George Chrisbacher]

I could be wrong, but I think this could be generalized. If you return false 
from the onKeyPress handler, the key press should not be propagated regardless 
of which key was pressed. In theory, you should be able to prevent the user 
from entering any given keypress, be it <Return> or the 'X' key, or whatever, 
into a given control.

In Mozilla, the keypress, and hence the character, seems to be reaching the 
control before the onKeyPress handler is even called, thus returning false has 
no effect.

Comment 5

[Kevin McCluskey (gone)]

Bulk reassigning form bugs to Alex

Comment 6

[Tal Dayan]

Attachment: Demonstrates how the form is posted before the event handler is completed

Comment 7

[Tal Dayan]

We encountered similar problem but I think it is related so I will add a 
comment here instead of opening a new but.

When we set an event handler, the handler is triggered OK when the Enter key is 
pressed but the form is submitted prematurely before the handler is completed 
(which means that returning 'false' from the handler will not suppress the form 
posting). The same code worked very well for us on NS 4.7 .

See attachment 'Demonstrates how the form is posted before the event handler is 
completed' for instructions how to reproduce it.

Comment 8

[Alexandru Savulov]

reassigning

Comment 9

[Alexandru Savulov]

reassigning (forgot to check the radio first time)

Comment 10

[saari (gone)]

dup of another soon to be in 0.9.9

Comment 11

[Peter Trudelle]

nsbeta1+ per ADT triage

Comment 12

[joki (gone)]

124990 and its associated bugs is not quite ready for checkin for 0.9.9. 
Maintaining high priority and moving to 1.0 for completion and further testing.

Comment 13

[Bob Clary [:bc] (inactive)]

-> eapp per oracle

Comment 14

[TucsonTester3]

this also happens on Windows XP as well as Windows ME

Comment 15

[Bob Clary [:bc] (inactive)]

Looks like we have missed the train for 1.0.1. Can we retarget this for 1.2?

Comment 16

[saari (gone)]

the work this depends upon will be landing soon

Comment 17

[Pham]

.

Comment 18

[Boris Zbarsky [:bzbarsky]]

This worksforme in a current build.  Also verified by code inspection that we
check whether the event was cancelled before triggering submit-on-enter.