Closed Bug 817403 Opened 8 years ago Closed 8 years ago

Remove the preskip check when playing opus chained file.

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: padenot, Assigned: padenot)

Details

Attachments

(1 file, 1 obsolete file)

Right now, we are checking that all the links in a chained Opus file have the same preskip value to continue to decode across links. This is unnecessary according to Derf.
As discussed on irc, this patch removes the check. I tried playing a couple
chained files that have different preskip values across links, and it seems
to work just fine.

I can add a file to the test suite if needed.
Attachment #687529 - Flags: review?(tterribe)
Assignee: nobody → paul
Comment on attachment 687529 [details] [diff] [review]
Remove the preskip check when playing opus chained file. r=

Review of attachment 687529 [details] [diff] [review]:
-----------------------------------------------------------------

> I can add a file to the test suite if needed.

That'd be great.
Attachment #687529 - Flags: review?(tterribe) → review+
Here is the final patch with the test file and related makefile and manifest
changes. Carrying forward r+.
Attachment #687529 - Attachment is obsolete: true
Attachment #687743 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/3e1a5a4f0da6
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.