817403 - Remove the preskip check when playing opus chained file.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Paul Adenot (:padenot)]

Right now, we are checking that all the links in a chained Opus file have the same preskip value to continue to decode across links. This is unnecessary according to Derf.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Remove the preskip check when playing opus chained file. r=

As discussed on irc, this patch removes the check. I tried playing a couple
chained files that have different preskip values across links, and it seems
to work just fine.

I can add a file to the test suite if needed.

Comment 2

[Timothy B. Terriberry (:derf)]

Comment on attachment 687529 [details] [diff] [review]
Remove the preskip check when playing opus chained file. r=

Review of attachment 687529 [details] [diff] [review]:
-----------------------------------------------------------------

> I can add a file to the test suite if needed.

That'd be great.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Remove the preskip check when playing opus chained file.

Here is the final patch with the test file and related makefile and manifest
changes. Carrying forward r+.

Comment 4

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e1a5a4f0da6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e1a5a4f0da6