Closed Bug 817419 Opened 8 years ago Closed 8 years ago

Fix warning about DebugScopes forward-declaration as struct

Categories

(Core :: JavaScript Engine, defect, P4)

x86
Windows 7
defect

Tracking

()

RESOLVED FIXED
mozilla20
Tracking Status
firefox19 --- unaffected
firefox20 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

(Keywords: regression)

Attachments

(1 file)

This small patch fixes a MSVC warning regression from bug 790338:

js\src\vm/ScopeObject.h(539) : warning C4099: 'js::DebugScopes' : type name first seen using 'struct' now seen using 'class'
js\src\jscompartment.h(118) : see declaration of 'js::DebugScopes'
js\src\vm/ScopeObject.h(539) : warning C4099: 'js::DebugScopes' : type name first seen using 'struct' now seen using 'class'
js\src\jscompartment.h(118) : see declaration of 'js::DebugScopes'
src\vm/ScopeObject.h(539) : warning C4099: 'js::DebugScopes' : type name first seen using 'struct' now seen using 'class'
js\src\jscompartment.h(118) : see declaration of 'js::DebugScopes'
Attachment #687539 - Flags: review?(jcoppeard)
Comment on attachment 687539 [details] [diff] [review]
fix-DebugScopes-warning.patch

Review of attachment 687539 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, cheers.
Attachment #687539 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f2e51e26e68
Severity: normal → minor
Target Milestone: --- → mozilla20
Whiteboard: [js:t]
https://hg.mozilla.org/mozilla-central/rev/3f2e51e26e68
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [js:t]
You need to log in before you can comment on or make changes to this bug.