817447 - downloads/browser_privatebrowsing.js fails on Birch on Windows

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[(no longer active)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=17538751&tree=Birch&full=1#error3

Note:

WARNING: Using integer IDs without compat mode enabled: file e:/builds/moz2_slave/bir-w32-dbg/build/toolkit/components/downloads/nsDownloadManager.cpp, line 1693

Comment 1

[Josh Matthews [:jdm]]

Looking at the various browser tests, I have realized that there is no actual benefit to using them as browser tests (since the window objects are never actually used). I have a patch in my queue that fixes up the various xpcshell tests to work correctly, and I'll remove the browser ones.

Comment 2

[(no longer active)]

(In reply to comment #1)
> Looking at the various browser tests, I have realized that there is no actual
> benefit to using them as browser tests (since the window objects are never
> actually used). I have a patch in my queue that fixes up the various xpcshell
> tests to work correctly, and I'll remove the browser ones.

Sounds good!

Comment 3

[Josh Matthews [:jdm]]

Attachment: Create download manager unit tests that do not rely on the global private browsing service.

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/94793d328713