Closed Bug 817447 Opened 7 years ago Closed 7 years ago

downloads/browser_privatebrowsing.js fails on Birch on Windows

Categories

(Toolkit :: Downloads API, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: ehsan, Assigned: jdm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=17538751&tree=Birch&full=1#error3

Note:

WARNING: Using integer IDs without compat mode enabled: file e:/builds/moz2_slave/bir-w32-dbg/build/toolkit/components/downloads/nsDownloadManager.cpp, line 1693
Looking at the various browser tests, I have realized that there is no actual benefit to using them as browser tests (since the window objects are never actually used). I have a patch in my queue that fixes up the various xpcshell tests to work correctly, and I'll remove the browser ones.
(In reply to comment #1)
> Looking at the various browser tests, I have realized that there is no actual
> benefit to using them as browser tests (since the window objects are never
> actually used). I have a patch in my queue that fixes up the various xpcshell
> tests to work correctly, and I'll remove the browser ones.

Sounds good!
Attachment #688929 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/94793d328713
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.