Closed
Bug 817451
Opened 12 years ago
Closed 12 years ago
Correctly set mRole in PC unit tests
Categories
(Core :: WebRTC: Signaling, defect)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: ekr, Assigned: ekr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
3.06 KB,
patch
|
ehugg
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
When PCImpl got refactored to add constraints to CreateOffer/CreateAnswer, we lost the code to set mRole correctly. This would break unit tests if they properly checked for media flowing or not (bug 798680)
Blocks: 798680
|
|
Assignee | |
Updated•12 years ago
|
Attachment #687584 -
Flags: review?(ethanhugg)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 687584 [details] [diff] [review] Correctly set mRole in PC unit tests Review of attachment 687584 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #687584 -
Flags: review?(ethanhugg) → review+
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/66bd36779628
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
||
Updated•12 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•