gfx/thebes/woff.o: requires dynamic R_X86_64_PC32 reloc against 'moz_malloc' which may overflow at runtime; recompile with -fPIC

RESOLVED FIXED in mozilla20

Status

()

Core
Graphics
--
blocker
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

({regression})

unspecified
mozilla20
x86_64
Linux
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
/OBJDIR/home/mats/moz/inbound/_virtualenv/bin/python /home/mats/moz/inbound/config/pythonpath.py -I../../config /home/mats/moz/inbound/config/expandlibs_exec.py --depend .deps/libxul.so.pp --target libxul.so --uselist --  clang++ -Qunused-arguments  -pedantic -Qunused-arguments -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wno-ctor-dtor-privacy -Wno-overlength-strings -Wno-invalid-offsetof -Wno-variadic-macros -Wno-c++0x-extensions -Wno-unknown-warning-option -Wno-return-type-c-linkage -Wno-mismatched-tags -Wno-long-long -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pthread -pipe  -DDEBUG -D_DEBUG -DTRACING -g -fno-omit-frame-pointer  -fPIC -shared -Wl,-z,defs -Wl,--gc-sections -Wl,-h,libxul.so -o libxul.so  nsStaticXULComponents.o nsUnicharUtils.o nsBidiUtils.o nsSpecialCasingData.o nsUnicodeProperties.o nsRDFResource.o    -lpthread  -Wl,-z,noexecstack -Wl,--icf=safe   -Wl,-rpath-link,/OBJDIR/home/mats/moz/inbound/dist/bin -Wl,-rpath-link,/usr/local/lib  ../../toolkit/components/osfile/libosfile_s.a ../../toolkit/xre/libxulapp_s.a  ../../staticlib/components/libnecko.a ../../staticlib/components/libuconv.a ../../staticlib/components/libi18n.a ../../staticlib/components/libchardet.a ../../staticlib/components/libjar50.a ../../staticlib/components/libstartupcache.a ../../staticlib/components/libpref.a ../../staticlib/components/libhtmlpars.a ../../staticlib/components/libidentity.a ../../staticlib/components/libimglib2.a ../../staticlib/components/libmediasniffer.a ../../staticlib/components/libgkgfx.a ../../staticlib/components/libgklayout.a ../../staticlib/components/libdocshell.a ../../staticlib/components/libembedcomponents.a ../../staticlib/components/libwebbrwsr.a ../../staticlib/components/libnsappshell.a ../../staticlib/components/libtxmgr.a ../../staticlib/components/libcommandlines.a ../../staticlib/components/libtoolkitcomps.a ../../staticlib/components/libpipboot.a ../../staticlib/components/libpipnss.a ../../staticlib/components/libappcomps.a ../../staticlib/components/libjsreflect.a ../../staticlib/components/libcomposer.a ../../staticlib/components/libtelemetry.a ../../staticlib/components/libjsinspector.a ../../staticlib/components/libjsdebugger.a ../../staticlib/components/libstoragecomps.a ../../staticlib/components/librdf.a ../../staticlib/components/libwindowds.a ../../staticlib/components/libjsctypes.a ../../staticlib/components/libjsperf.a ../../staticlib/components/libgkplugin.a ../../staticlib/components/libunixproxy.a ../../staticlib/components/libjsd.a ../../staticlib/components/libautoconfig.a ../../staticlib/components/libauth.a ../../staticlib/components/libcookie.a ../../staticlib/components/libpermissions.a ../../staticlib/components/libuniversalchardet.a ../../staticlib/components/libfileview.a ../../staticlib/components/libplaces.a ../../staticlib/components/libtkautocomplete.a ../../staticlib/components/libsatchel.a ../../staticlib/components/libpippki.a ../../staticlib/components/libwidget_gtk2.a ../../staticlib/components/libimgicon.a ../../staticlib/components/libprofiler.a ../../staticlib/components/libaccessibility.a ../../staticlib/components/libremoteservice.a ../../staticlib/components/libspellchecker.a ../../staticlib/components/libzipwriter.a ../../staticlib/components/libservices-crypto.a ../../staticlib/components/libgkdebug.a ../../staticlib/components/libnkgio.a ../../staticlib/libjsipc_s.a ../../staticlib/libdomipc_s.a ../../staticlib/libdomplugins_s.a ../../staticlib/libmozipc_s.a ../../staticlib/libmozipdlgen_s.a ../../staticlib/libipcshell_s.a ../../staticlib/libgfxipc_s.a ../../staticlib/libhal_s.a ../../staticlib/libdombindings_s.a ../../staticlib/libxpcom_core.a ../../staticlib/libucvutil_s.a ../../staticlib/libchromium_s.a ../../staticlib/libsnappy_s.a ../../staticlib/libgtkxtbin.a ../../staticlib/libthebes.a ../../staticlib/libgl.a ../../staticlib/libycbcr.a  -L../../dist/bin -L../../dist/lib /OBJDIR/home/mats/moz/inbound/dist/lib/libjs_static.a -L../../dist/bin -L../../dist/lib -lcrmf -lsmime3 -lssl3 -lnss3 -lnssutil3   -lXrender  ../../dist/lib/libmozsqlite3.a  /OBJDIR/home/mats/moz/inbound/modules/zlib/src/libmozz.a ../../dist/lib/libgkmedias.a -lasound   -lrt -L../../dist/bin -L../../dist/lib  -L/OBJDIR/home/mats/moz/inbound/dist/lib -lnspr4 -lplc4 -lplds4 ../../dist/lib/libmozalloc.a -ldbus-glib-1 -ldbus-1 -lpthread -lrt -lgobject-2.0 -lglib-2.0    -lX11  -lXext  -lpangoft2-1.0 -lfreetype -lfontconfig -lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0 -lglib-2.0   -lfontconfig   -lgtk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lfreetype -lfontconfig -lgdk-x11-2.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lpango-1.0 -lcairo -lgobject-2.0 -lglib-2.0   -lXt -lgthread-2.0 -lfreetype    -ldl  -lrt    
/usr/bin/ld: error: /md1/OBJDIR/home/mats/moz/inbound/toolkit/library/../../gfx/thebes/woff.o: requires dynamic R_X86_64_PC32 reloc against 'moz_malloc' which may overflow at runtime; recompile with -fPIC
/usr/bin/ld: error: hidden symbol 'moz_free' is not defined locally
/usr/bin/ld: error: hidden symbol 'moz_malloc' is not defined locally
[... a few hundred of those errors ...]
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[5]: *** [libxul.so] Error 1
(Assignee)

Comment 1

6 years ago
Created attachment 687595 [details] [diff] [review]
temporary workaround

This fixed it for me...
(Assignee)

Comment 2

6 years ago
Regression is from bug 801466.
Blocks: 801466
Keywords: regression
does including mozilla/mozalloc.h fix the build for you?
(Assignee)

Comment 4

6 years ago
Created attachment 687726 [details] [diff] [review]
fix

Yeah, this works for me.
Attachment #687726 - Flags: review?(trev.saunders)
Comment on attachment 687726 [details] [diff] [review]
fix

your probably more qualified to review this stuff than me, but seems fine so rs=me
Attachment #687726 - Flags: review?(trev.saunders) → review+
https://hg.mozilla.org/mozilla-central/rev/d40a7db7d9a0
Assignee: nobody → matspal
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.