817469 - Make XPCOM ParseFromString a wrapper for WebIDL ParseFromString

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

https://bugzilla.mozilla.org/show_bug.cgi?id=816410#c18
> One followup we should get filed: the canonical implementation of
> ParseFromString should be the WebIDL one, because the actual implementation
> converts the PRUnichar* to a nsAString anyway, and as things are written
> right now passing a string with null to the WebIDL method would truncate at
> the null for no good reason....

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Correctly handle embedded null in the string to parse in DOMParser.

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 687799 [details] [diff] [review]
Correctly handle embedded null in the string to parse in DOMParser.

>--- a/content/base/test/Makefile.in
>+++ b/content/base/test/Makefile.in
>@@ -595,16 +595,17 @@ MOCHITEST_FILES_B = \
> 		test_bug804395.html \
> 		test_bug809003.html \
> 		test_textnode_split_in_selection.html \
> 		test_textnode_normalize_in_selection.html \
> 		test_xhr_send_readystate.html \
> 		test_bug813919.html \
> 		test_bug814576.html \
> 		test_xhr_withCredentials.html \
>+		test_domparser_null_char.html \

Please add the test file at the bottom of MOCHITEST_FILES_A that has fewer files than MOCHITEST_FILES_B.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75a0cf19f231 with that change.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/75a0cf19f231