817553 - Fade the highlighter when sidebar is hovered.

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Paul Rouget [:paul]]

It used to work. Regression since toolbox.

Comment 1

[Girish Sharma [:Optimizer]]

Attachment: Hide on sidebar hover

Comment 2

[Paul Rouget [:paul]]

Comment on attachment 692624 [details] [diff] [review]
Hide on sidebar hover

The title of this bug is misleading. We want to hide the highlighter only when the ruleview is hovered (because we don't want the highlighter to disturb the user while change the style of the node).

Comment 3

[Girish Sharma [:Optimizer]]

So not on Computed view and/or Box Model ?

Comment 4

[Paul Rouget [:paul]]

(In reply to Girish Sharma [:Optimizer] from comment #3)
> So not on Computed view and/or Box Model ?

right.

Comment 5

[Girish Sharma [:Optimizer]]

Attachment: only ruleview

Hide highlighter only on ruleview hover

Comment 6

[Girish Sharma [:Optimizer]]

Attachment: only ruleview

Hide highlighter only on ruleview hover

Comment 7

[Paul Rouget [:paul]]

Comment on attachment 692994 [details] [diff] [review]
only ruleview

Can you try to get the same behavior but without putting the event logic in Sidebar.jsm? Basically, don't touch Sidebar.jsm and move the event listeners in Inspector.jsm? If it doesn't work, I'm ok to keep your current approach.

Comment 8

[Girish Sharma [:Optimizer]]

This makes things a bit more generic, other consumers of sidebar can also use the event.
Otherwise, I could add a method to get reference to a specific tab panel in the sidebar, then use that to add eventListener to ruleview tab ..

Comment 9

[Paul Rouget [:paul]]

(In reply to Girish Sharma [:Optimizer] from comment #8)
> This makes things a bit more generic, other consumers of sidebar can also
> use the event.

This behavior is so unique that I really don't think we should be generic.

Comment 10

[Girish Sharma [:Optimizer]]

Attachment: patch v2.0

Done.

Added getTab method to get reference to the tab, and then added the event listeners in inspector panel only.

Comment 11

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/bb4bce1a3348

Comment 12

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/bb4bce1a3348