Closed Bug 817553 Opened 9 years ago Closed 9 years ago

Fade the highlighter when sidebar is hovered.

Categories

(DevTools :: Inspector, defect, P3)

x86
All
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: paul, Assigned: Optimizer)

References

Details

Attachments

(1 file, 3 obsolete files)

It used to work. Regression since toolbox.
Component: Developer Tools → Developer Tools: Inspector
Priority: -- → P3
Attached patch Hide on sidebar hover (obsolete) — Splinter Review
Assignee: nobody → scrapmachines
Status: NEW → ASSIGNED
Attachment #692624 - Flags: review?(paul)
Whiteboard: [has-patch]
Comment on attachment 692624 [details] [diff] [review]
Hide on sidebar hover

The title of this bug is misleading. We want to hide the highlighter only when the ruleview is hovered (because we don't want the highlighter to disturb the user while change the style of the node).
Attachment #692624 - Flags: review?(paul) → review-
So not on Computed view and/or Box Model ?
(In reply to Girish Sharma [:Optimizer] from comment #3)
> So not on Computed view and/or Box Model ?

right.
Attached patch only ruleview (obsolete) — Splinter Review
Hide highlighter only on ruleview hover
Attachment #692624 - Attachment is obsolete: true
Attachment #692992 - Flags: review?(paul)
Attached patch only ruleview (obsolete) — Splinter Review
Hide highlighter only on ruleview hover
Attachment #692992 - Attachment is obsolete: true
Attachment #692992 - Flags: review?(paul)
Attachment #692994 - Flags: review?(paul)
Comment on attachment 692994 [details] [diff] [review]
only ruleview

Can you try to get the same behavior but without putting the event logic in Sidebar.jsm? Basically, don't touch Sidebar.jsm and move the event listeners in Inspector.jsm? If it doesn't work, I'm ok to keep your current approach.
Attachment #692994 - Flags: review?(paul) → review-
This makes things a bit more generic, other consumers of sidebar can also use the event.
Otherwise, I could add a method to get reference to a specific tab panel in the sidebar, then use that to add eventListener to ruleview tab ..
(In reply to Girish Sharma [:Optimizer] from comment #8)
> This makes things a bit more generic, other consumers of sidebar can also
> use the event.

This behavior is so unique that I really don't think we should be generic.
Attached patch patch v2.0Splinter Review
Done.

Added getTab method to get reference to the tab, and then added the event listeners in inspector panel only.
Attachment #692994 - Attachment is obsolete: true
Attachment #693036 - Flags: review?(paul)
Attachment #693036 - Flags: review?(paul) → review+
Whiteboard: [has-patch] → [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/bb4bce1a3348
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/bb4bce1a3348
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.