Closed
Bug 817578
Opened 12 years ago
Closed 12 years ago
BaselineCompiler: Compile SUB and MUL
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
14.06 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #687748 -
Flags: review?(kvijayan)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 687748 [details] [diff] [review]
Patch
Review of attachment 687748 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/arm/BaselineIC-arm.cpp
@@ +137,5 @@
> + masm.bind(&maybeNegZero);
> +
> + // Result is -0 if lhs or rhs is negative.
> + masm.ma_cmn(R0.payloadReg(), R1.payloadReg());
> + masm.j(Assembler::Signed, &failure);
Nit: Comment would be better if it's a bit more explicit: "Result is -0 if exactly one of lhs or rhs is negative."
Attachment #687748 -
Flags: review?(kvijayan) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Pushed with comment nit fixed:
https://hg.mozilla.org/projects/ionmonkey/rev/2a8adc47f35a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•