From bug 787578: > http://dxr.mozilla.org/mozilla-central/toolkit/mozapps/update/test/ > http://dxr.mozilla.org/mozilla-central/toolkit/mozapps/update/test_svc/ don't appear to be present in the tests.zip. They'll need to be added.
test_svc is windows only I think we need these: test test_timermanager
So it looks like this is happening because MOZ_UPDATER isn't being defined: http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/Makefile.in#53 Maybe this gets defined in the builds releng provides and this bug isn't an issue. Or maybe we need to define this when building B2G. I'm not the right person to answer this. Brian, if you don't know the answer any idea who might?
If you want the tests to run, yes it should be defined. If you'd like to make a build that knows nothing about updating then you should not define it.
I downloaded a tests.zip from ftp.m.o and it looks like MOZ_UPDATER isn't defined there either. Morphing title and component.
Component: XPCShell Harness → Builds
Product: Testing → Boot2Gecko
Summary: Update tests not included in test-package-stage → Define MOZ_UPDATER in ics_armv7a_gecko builds to get xpcshell update tests
Marshall, do you know the build config to enable this?
blocking-basecamp: + → ---
Sorry, unset the basecamp+
blocking-basecamp: --- → ?
I spoke with Andrew about this today. The two requirements for this bug are 1. determine the required build params (see comment 5 for Marshall) 2. add the config to the build (likely on releng) Setting the basecamp flag back to + as Andrew renomed by accident.
blocking-basecamp: ? → +
Chris - Andrew suggested that someone from releng should set the build config once we know what it is. Can you help find someone to take this?
Assignee: nobody → catlee
Can this setting be provided in the mozconfig? https://hg.mozilla.org/mozilla-central/file/e83769592c61/b2g/config/mozconfigs/ics_armv7a_gecko/nightly
I found: https://github.com/mozilla-b2g/gonk-misc/blob/master/default-gecko-config#L44 Not sure if you also need to specify --enable-update-channel or --enable-update-packaging or if there are any negative side effects of doing --enable-updater. Jgriffin or marshall, care to weigh in?
Added --enable-updater only and pushed to try to see what happens: https://tbpl.mozilla.org/?tree=Try&rev=e75ad58d9201
Created attachment 690412 [details] [diff] [review] Patch 1.0 - Add --enable-updater I checked the try run and the update tests do get included in tests.zip with this patch
Attachment #690412 - Flags: review?(catlee)
Status: NEW → ASSIGNED
(In reply to Andrew Halberstadt [:ahal] from comment #5) > Marshall, do you know the build config to enable this? Yeah, we automatically enable updates for the "user" and "userdebug" build variants in AOSP, i.e: $ VARIANT=user ./build.sh or.. $ VARIANT=userdebug ./build.sh Alternatively, you can also use B2G_UPDATER=1: $ B2G_UPDATER=1 ./build.sh IIRC, these will also enable app updates
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
status-firefox18: --- → fixed
status-firefox19: --- → fixed
status-firefox20: --- → fixed
You need to log in before you can comment on or make changes to this bug.