817670 - TEST FAILED: test-net-url.test async readURI with not existing file (exception)

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

info: addon-sdk: executing 'test-net-url.test async readURI with not existing file'
error: addon-sdk: TEST FAILED: test-net-url.test async readURI with not existing file (exception)
error: addon-sdk: An exception occurred.
Traceback (most recent call last):
  File "resource://a17aa2cd-f8f6-45d7-a995-02c918a00cc8-at-jetpack/addon-sdk/lib/sdk/timers.js", line 31, in notify
    callback.apply(null, args);
  File "resource://a17aa2cd-f8f6-45d7-a995-02c918a00cc8-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 267, in null
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://a17aa2cd-f8f6-45d7-a995-02c918a00cc8-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 419, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://a17aa2cd-f8f6-45d7-a995-02c918a00cc8-at-jetpack/addon-sdk/lib/sdk/deprecated/unit-test.js", line 444, in start
    this.test.testFunction(this);
  File "resource://a17aa2cd-f8f6-45d7-a995-02c918a00cc8-at-jetpack/addon-sdk/lib/sdk/test.js", line 64, in null
    test(assert, function() {
  File "resource://a17aa2cd-f8f6-45d7-a995-02c918a00cc8-at-jetpack/addon-sdk/tests/test-net-url.js", line 87, in exports["test async readURI with not existing file"]
    readURI(data.url("test-net-url-fake.txt")).then(function(data) {
  File "resource://a17aa2cd-f8f6-45d7-a995-02c918a00cc8-at-jetpack/addon-sdk/lib/sdk/net/url.js", line 76, in readURI
    : readAsync(uri, options.charset);
  File "resource://a17aa2cd-f8f6-45d7-a995-02c918a00cc8-at-jetpack/addon-sdk/lib/sdk/net/url.js", line 37, in readAsync
    NetUtil.asyncFetch(channel, function (stream, result) {
  File "resource://gre/modules/NetUtil.jsm", line 165, in NetUtil_asyncOpen
    channel.asyncOpen(listener, null);
[Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIChannel.asyncOpen]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/NetUtil.jsm :: NetUtil_asyncOpen :: line 165"  data: no]


This has been orange on Inbound since at least last Wednesday. Still trying to get back to the start of the failures.

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/675

Pointer to Github pull-request

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/de6aa237e1100d34a0dc4cfe386f637fb6a2748c
Merge pull request #675 from Gozala/bug/panel-test@17670

Bug 817670 - Fix failing panel tests on nightly. r=@Mossop

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Ugh, committed to inbound using this bugnumber for the panel test fixes, but that's not what this bug really is.

Oh well http://hg.mozilla.org/integration/mozilla-inbound/rev/a1bf69c53c01

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/a1bf69c53c01

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Oops, forgot the leave open tag, since the actual bug in here is still not fixed.

Comment 6

[Gabor Krizsanits (INACTIVE)]

So reading a non-existing file throws an NS_ERROR_FILE_NOT_FOUND. At first glance this looks like something that should be addressed on SDK part to be honest (a try catch block in url.js). I could not find any recent platform patch that would result this change. If it's needed I could spend more time on it, but since it's relatively easy to fix on sdk side, and a sane behavior I'm not sure I should.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Gabor Krizsanits [:krizsa :gabor] from comment #6)
> I could not find any recent platform patch that would result this change. 


The test failure first showed up on tbpl when bug 814195 landed.

Comment 8

[Dave Townsend [:mossop]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/694

Pointer to Github pull-request

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/73d8a8b0e8f9b4308ded44d48f35a5173740ddaf
Merge pull request #694 from Mossop/bug817670

Fixes Bug 817670: Catch exceptions from NetUtil.asyncFetch. r=@ZER0

Comment 10

[[github robot]]

Commit pushed to release at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/cf95364fac46262ac05202b7fb530eea3077310e
Merge pull request #694 from Mossop/bug817670

Fixes Bug 817670: Catch exceptions from NetUtil.asyncFetch. r=@ZER0(cherry picked from commit 73d8a8b0e8f9b4308ded44d48f35a5173740ddaf)

Comment 11

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/cf95364fac46262ac05202b7fb530eea3077310e
Merge pull request #694 from Mossop/bug817670