Closed
Bug 817671
Opened 13 years ago
Closed 13 years ago
[AccessFu] Fix window scrolling
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: eeejay, Assigned: eeejay)
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
The scroll() method takes an absolute value (scroll to position), not a relative value (scroll by value). Currently the latter is done.
|
Assignee | |
Comment 1•13 years ago
|
||
Above a mean the DOM window.scroll()
Attachment #687838 -
Flags: review?(dbolter)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 687838 [details] [diff] [review]
Fix window scrolling
Review of attachment 687838 [details] [diff] [review]:
-----------------------------------------------------------------
r=me. I haven't tested.
::: accessible/src/jsat/content-script.js
@@ -191,5 @@
> // Scroll window.
> if (!horiz && content.scrollMaxY &&
> ((page > 0 && content.scrollY < content.scrollMaxY) ||
> (page < 0 && content.scrollY > 0))) {
> - content.scroll(0, content.innerHeight);
Heh. That was funny :)
Attachment #687838 -
Flags: review?(dbolter) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e182b6179f6
Oops. I put blassey's name on the r+
Assignee: nobody → eitan
|
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•