817705 - [toolbox] Disable Inspect Mode when switching tools in Toolbox

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Rob Campbell [:rc] (:robcee)]

STR:

1. Open Toolbox via Inspect keyboard shortcut (Cmd-alt-I)
2. Select another tool in the Toolbox Toolbar, e.g., Web Console.

Expected Results:
Highlighter is locked on last hovered item. (Alternately, highlighter could go away)

Actual:
We stay in Inspect mode and the highlighter selection follows mouse in content.

Comment 1

[Rob Campbell [:rc] (:robcee)]

Nightly: 20.0a1 (2012-12-03).

Comment 2

[Paul Rouget [:paul]]

Indeed, we just hide instead of disabling.

Comment 3

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 4

[Paul Rouget [:paul]]

review ping?

Comment 5

[Joe Walker [:jwalker]]

Comment on attachment 690854 [details] [diff] [review]
patch v1

Review of attachment 690854 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/inspector/Highlighter.jsm
@@ +144,5 @@
>          this.hide();
>        } else {
> +        if (!this.locked) {
> +          this.attachMouseListeners();
> +        }

Is this a better way of doing this than adding/removing the listeners/timeouts in show/hide?

Comment 6

[Paul Rouget [:paul]]

(In reply to Joe Walker [:joe_walker] [:jwalker] from comment #5)
> Comment on attachment 690854 [details] [diff] [review]
> patch v1
> 
> Review of attachment 690854 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/devtools/inspector/Highlighter.jsm
> @@ +144,5 @@
> >          this.hide();
> >        } else {
> > +        if (!this.locked) {
> > +          this.attachMouseListeners();
> > +        }
> 
> Is this a better way of doing this than adding/removing the
> listeners/timeouts in show/hide?

Yes. We might want to hide but keep the highlighting mechanism.

Comment 7

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/3f2d435dfe60

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/3f2d435dfe60