817780 - Work - Holding down the left mouse button causes context menu to appear

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect)

Description

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Holding down the left mouse button shouldn't do anything special; it should be equivalent to holding down the left mouse button on desktop Firefox.

I couldn't find anything in widget that seemed like a cause for this.  Specifically, we don't get a RightTapped event in the case that the left mouse button is held down, so we don't send a NS_CONTEXT_MENU gecko event.

Comment 1

[Wesley Johnston (:wesj)]

There's a pref for this: http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsEventStateManager.cpp#869

Comment 2

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

(In reply to Wesley Johnston (:wesj) from comment #1)
> There's a pref for this:
> http://mxr.mozilla.org/mozilla-central/source/content/events/src/
> nsEventStateManager.cpp#869

So there is!  Disabling that pref does indeed cause left-click-and-hold to stop bringing up the context menu, but it also causes right-click to stop bringing up the context menu.  It seems like there's a more complex relationship between widget, front-end code, and the EventStateManager than I previously thought.

Does anyone know why we're setting "ui.click_hold_context_menus" to true by default on Firefox for Windows immersive mode?  It seems to me that we don't want this, since widget will already send NS_CONTEXT_MENU if a user does a tap-and-hold, and since mouse interaction should work basically the same as it does in desktop Firefox.

Comment 3

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: patch v1

This seems to fix the issue. This patch sets "ui.click_hold_context_menus" to false by default, and removes some code in widget that was avoiding sending NS_CONTEXT_MENU twice (this might still be an issue if users manually set "ui.click_hold_context_menus" to true, so if we want to support "ui.click_hold_context_menus" then we'll probably want to add some code that checks for the pref being set and sends NS_CONTEXT_MENU conditionally)

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 688339 [details] [diff] [review]
patch v1

don't think we need to worry about checking the pref at this point.

Comment 5

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Pushed to elm:
https://hg.mozilla.org/projects/elm/rev/9b534eb20b72

Build containing patch:
https://tbpl.mozilla.org/?tree=Elm&rev=9b534eb20b72

Comment 6

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.