817805 - Remove UA override for wikipedia.org

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P3)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

In bug 798693 we added a UA override for wikipedia.org. Wikipedia has since fixed their UA detection to recognize B2G as a mobile browser. (See https://bugzilla.wikimedia.org/show_bug.cgi?id=40919) I have confirmed that Wikipedia serves mobile content to Firefox for Android using a B2G UA. We should remove the Wikipedia override from the whitelist.

Benoit - Sorry for the churn. As you added the whitelist entry can you also please back it out?

Comment 1

[Ben Francis [:benfrancis]]

What's the correct component for UA overrides? It certainly isn't done in Gaia.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: remove UA override for wikipedia

No worries. Sounds like the process is working.

Comment 3

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Ben Francis [:benfrancis] from comment #1)
> What's the correct component for UA overrides? It certainly isn't done in
> Gaia.

AFAIK Gaia is the correct component. Bug 798693 has the source reference for the addition of the UA override for wikipedia.org.

Comment 4

[Ben Francis [:benfrancis]]

Oh, so it is done in Gaia! Who would have thunk it.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Benoit, is there a PR that I can merge directly?

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Sorry, forgot; just made one: https://github.com/mozilla-b2g/gaia/pull/6948

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/f8769d1d08b54386cced34984bb7c95fba7ec41f

Comment 8

[cbarker]

The default UA loaded mobile site as expected.  
Verified fixed in Unagi Build 20130103070201