817812 - Fix --enable-root-analysis compile

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

The recent jsgc.cpp splitup removed some functions that my rooting analysis optimization depended on.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Fix --enable-root-analysis compile

This patch exposes a simplified IsAddressableGCThing overload and uses it.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 687946 [details] [diff] [review]
Fix --enable-root-analysis compile

Review of attachment 687946 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine to me.

::: js/src/gc/GCInternals.h
@@ +83,5 @@
>  IncrementalSafety
>  IsIncrementalGCSafe(JSRuntime *rt);
>  
> +bool
> +IsAddressableGCThing(JSRuntime *rt, uintptr_t w);

At some point in the future, this is going to be the last link holding the conservative GC testing alive. Put this under #ifdef ROOT_ANALYIS so that it's perfectly clear what is depending on the functionality.

::: js/src/gc/Verifier.cpp
@@ +283,5 @@
>  
>      JS_ASSERT(stackMin <= stackEnd);
>      CheckStackRootsRangeAndSkipIon(rt, stackMin, stackEnd, firstToScan, rooters.end());
>      CheckStackRootsRange(rt, cgcd->registerSnapshot.words,
> +                         mozilla::ArrayEnd(cgcd->registerSnapshot.words),

This is just the verifier, we should |using namespace mozilla;| at the top.

Comment 3

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/72859dc0fefd

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/72859dc0fefd