817844 - Remove DOMClassInfo remnants from DOMParser/XMLSerializer

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

>--- a/content/base/src/nsDOMSerializer.cpp
>+++ b/content/base/src/nsDOMSerializer.cpp
>@@ -1,43 +1,39 @@
> nsDOMSerializer::nsDOMSerializer()
> {
>+  SetIsDOMBinding();
> }
I shot my foot again :(

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 688013 [details] [diff] [review]
patch

Failed xpcshell tests :(
https://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]

Comment 3

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=7669512fa4cf

Comment 4

[Masatoshi Kimura [:emk]]

OK, I found the cause of failure.
  serializer.serializeToStream(doc, stream, null);
worked when serializer was XPC binding, but throws 0x80500001 if serializer is WebIDL binding. Because null will be converted into the string "null" and "null" is not a valid charset name.
The WebIDL signature should be something like:
  [Throws, ChromeOnly]
  void serializeToStream(Node root, OutputStream stream, DOMString? charset);

Comment 5

[Masatoshi Kimura [:emk]]

0x80500001 is NS_ERROR_UCONV_NOCONV.
Both parseFromStream and serializeToStream allowed the null charset parameter by contract.
https://mxr.mozilla.org/mozilla-central/source/content/base/public/nsIDOMSerializer.idl?rev=f4157e8c4107#31
https://mxr.mozilla.org/mozilla-central/source/content/base/public/nsIDOMParser.idl?rev=a16372ce30b5#48

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Part 1: Fix WebIDL signature of serializeToStream/parseFromStream

Comment 7

[Masatoshi Kimura [:emk]]

Attachment: Part 2: Remove DOMClassInfo remnants from DOMParser/XMLSerializer

Comment 8

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=a58ee36befa0

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 688451 [details] [diff] [review]
Part 1: Fix WebIDL signature of serializeToStream/parseFromStream

r=me

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 688452 [details] [diff] [review]
Part 2: Remove DOMClassInfo remnants from DOMParser/XMLSerializer

r=me

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/496577951cc2
https://hg.mozilla.org/integration/mozilla-inbound/rev/c20d8d5480e1

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/496577951cc2
https://hg.mozilla.org/mozilla-central/rev/c20d8d5480e1