Last Comment Bug 817846 - Add BaseSize::IsEmpty()
: Add BaseSize::IsEmpty()
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: 19 Branch
: All All
-- normal (vote)
: mozilla21
Assigned To: Usurelu Catalin
: Milan Sreckovic [:milan]
Depends on:
Blocks: 819664
  Show dependency treegraph
Reported: 2012-12-03 15:31 PST by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2013-01-24 09:48 PST (History)
7 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Added IsEmpty() member function (757 bytes, patch)
2012-12-15 14:55 PST, Usurelu Catalin
cjones.bugs: review+
Details | Diff | Splinter Review

Description User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-12-03 15:31:38 PST
Which means width != 0 && height != 0.

Will probably want a round of bikeshedding on this.
Comment 1 User image Vladimir Vukicevic [:vlad] [:vladv] 2012-12-03 15:37:08 PST
Can I bikeshed that "width != 0 && height != 0" does not mean IsEmpty? :)

(Did you mean "width == 0 || height == 0"?)
Comment 2 User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-12-03 15:39:02 PST
I did, thanks!
Comment 3 User image Usurelu Catalin 2012-12-15 14:55:31 PST
Created attachment 692659 [details] [diff] [review]
Added IsEmpty() member function

I'm not sure if I need to do anything else ...
Comment 4 User image Tobias (:Tobbi) Markus 2013-01-23 11:41:41 PST
Clearing [good first bug] flag and adding checkin-needed.
Comment 5 User image Ryan VanderMeulen [:RyanVM] 2013-01-23 15:08:02 PST
Thanks for the patch, Usurelu! One request, to make life easier for those checking in on your behalf, please make sure that future patches follow the guidelines at the link below so that they have all the metadata needed for checkin. Thanks!
Comment 6 User image Ryan VanderMeulen [:RyanVM] 2013-01-23 15:11:40 PST
Comment 7 User image Ryan VanderMeulen [:RyanVM] 2013-01-24 09:48:40 PST

Note You need to log in before you can comment on or make changes to this bug.