Which means width != 0 && height != 0. Will probably want a round of bikeshedding on this.
Can I bikeshed that "width != 0 && height != 0" does not mean IsEmpty? :) (Did you mean "width == 0 || height == 0"?)
I did, thanks!
Created attachment 692659 [details] [diff] [review] Added IsEmpty() member function I'm not sure if I need to do anything else ...
Attachment #692659 - Flags: review?(jones.chris.g)
6 years ago
Attachment #692659 - Flags: review?(jones.chris.g) → review+
Clearing [good first bug] flag and adding checkin-needed.
Whiteboard: [good first bug]
Thanks for the patch, Usurelu! One request, to make life easier for those checking in on your behalf, please make sure that future patches follow the guidelines at the link below so that they have all the metadata needed for checkin. Thanks! https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Assignee: nobody → catalin.usurelu5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.