Closed Bug 817846 Opened 7 years ago Closed 7 years ago

Add BaseSize::IsEmpty()

Categories

(Core :: Graphics, defect)

19 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: cjones, Assigned: catalin.usurelu5)

References

Details

Attachments

(1 file)

Which means width != 0 && height != 0.

Will probably want a round of bikeshedding on this.
Can I bikeshed that "width != 0 && height != 0" does not mean IsEmpty? :)

(Did you mean "width == 0 || height == 0"?)
I'm not sure if I need to do anything else ...
Attachment #692659 - Flags: review?(jones.chris.g)
Attachment #692659 - Flags: review?(jones.chris.g) → review+
Clearing [good first bug] flag and adding checkin-needed.
Keywords: checkin-needed
Whiteboard: [good first bug]
Thanks for the patch, Usurelu! One request, to make life easier for those checking in on your behalf, please make sure that future patches follow the guidelines at the link below so that they have all the metadata needed for checkin. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
https://hg.mozilla.org/mozilla-central/rev/8ff961a90f5e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.