Last Comment Bug 817846 - Add BaseSize::IsEmpty()
: Add BaseSize::IsEmpty()
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: 19 Branch
: All All
: -- normal (vote)
: mozilla21
Assigned To: Usurelu Catalin
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks: 819664
  Show dependency treegraph
 
Reported: 2012-12-03 15:31 PST by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2013-01-24 09:48 PST (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Added IsEmpty() member function (757 bytes, patch)
2012-12-15 14:55 PST, Usurelu Catalin
cjones.bugs: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-12-03 15:31:38 PST
Which means width != 0 && height != 0.

Will probably want a round of bikeshedding on this.
Comment 1 Vladimir Vukicevic [:vlad] [:vladv] 2012-12-03 15:37:08 PST
Can I bikeshed that "width != 0 && height != 0" does not mean IsEmpty? :)

(Did you mean "width == 0 || height == 0"?)
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-12-03 15:39:02 PST
I did, thanks!
Comment 3 Usurelu Catalin 2012-12-15 14:55:31 PST
Created attachment 692659 [details] [diff] [review]
Added IsEmpty() member function

I'm not sure if I need to do anything else ...
Comment 4 Tobias (:Tobbi) Markus 2013-01-23 11:41:41 PST
Clearing [good first bug] flag and adding checkin-needed.
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-01-23 15:08:02 PST
Thanks for the patch, Usurelu! One request, to make life easier for those checking in on your behalf, please make sure that future patches follow the guidelines at the link below so that they have all the metadata needed for checkin. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-01-23 15:11:40 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ff961a90f5e
Comment 7 Ryan VanderMeulen [:RyanVM] 2013-01-24 09:48:40 PST
https://hg.mozilla.org/mozilla-central/rev/8ff961a90f5e

Note You need to log in before you can comment on or make changes to this bug.