817879 - Bad paths in devtools

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Jim Mathies [:jimm]]

-Cu.import("resource://gre/modules/devtools/gcli.jsm");
+Cu.import("resource:///modules/devtools/gcli.jsm");

Comment 1

[Jim Mathies [:jimm]]

Attachment: fix

Comment 2

[Jim Mathies [:jimm]]

There are a few more like this.

Comment 3

[Jim Mathies [:jimm]]

Attachment: fixes part 2

Comment 4

[Joe Walker [:jwalker]]

Thanks for the fixes. Is there anything we should be doing to be warned earlier if we make this typo again?

Comment 5

[Jim Mathies [:jimm]]

(In reply to Joe Walker [:joe_walker] [:jwalker] from comment #4)
> Thanks for the fixes. Is there anything we should be doing to be warned
> earlier if we make this typo again?

Not really, currently you wouldn't know about it by doing a try build. App and gre have been mixed in the same locations forever. The work in bug 755724 should land soon which will split app and gre into separate locations, after which tests will catch these.

Comment 6

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69c58da43140

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/69c58da43140