817885 - Can't upload profiles to cleopatra

Status: VERIFIED FIXED

(Core :: Gecko Profiler, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Profile file

Probably not the right place to file this, but I don't know what is ;).

STR
 (1) Open cleopatra
 (2) Try to upload attached profile

The upload fails with no error indicated in the UI.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

I can't reproduce it:
http://people.mozilla.org/~bgirard/cleopatra/#report=e65ea71d4f1c455de0b06a21376e750d84e51463

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

11-28 nightly here.  Let's see if an update makes it go away.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Same results in 12-3.  Console output

...
[16:59:17.527] parsing (in worker): 1111ms
[16:59:17.528] posting message to worker: 0ms
[16:59:17.629] profile filtering (in worker): 91ms.
[16:59:17.634] TypeError: document.getElementById(...) is null @ http://people.mozilla.com/~bgirard/cleopatra/js/ui.js:1261
[16:59:17.657] reading data from worker message: 11ms
[16:59:17.663] histogram displaying: 6ms.
[16:59:17.746] diagnostic items displaying: 2ms.
[16:59:17.791] tree displaying: 15ms.
[16:59:17.843] tree displaying: 6ms.

Comment 4

[Benoit Girard (:BenWa)]

Fixed and deployed:
https://github.com/bgirard/cleopatra/commit/12c2d6cc9005f7eab8031309fd48f371d204e95a

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Thanks!