817913 - shouldn't have static functions in GfxDriverInfo.h

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Cameron McCormack (:heycam)]

I don't think it's a good idea to have static functions in GfxDriverInfo.h, as every translation unit that includes it (and uses them) gets its own copies.  It results in compiler warnings about the functions not being used in those translation units that they aren't.

I suggest doing either s/static/inline/ on them, or declaring them as non-inline functions and moving their implementations to the cpp file.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch

Make them inline.

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 688061 [details] [diff] [review]
patch

Review of attachment 688061 [details] [diff] [review]:
-----------------------------------------------------------------

Seems good to me! Are we sure this file never gets included from C-code? i.e. we don't need static inline?

Comment 3

[Cameron McCormack (:heycam)]

Couldn't see any.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d3c65ce01ad

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1d3c65ce01ad